Giter VIP home page Giter VIP logo

hnccorr's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hnccorr's Issues

Motion Correction

Hi,

Thank you for this package! Does this assume motions are already been corrected?

Bests
Abed

np.bool deprecated and needs replacing

 191     mask = np.full(movie_pixel_shape, False, dtype=np.bool)
    193     indices = tuple(zip(*self.selection))
    194     mask[indices] = True

File ~/miniforge3/envs/hnc/lib/python3.8/site-packages/numpy/__init__.py:305, in __getattr__(attr)
    300     warnings.warn(
    301         f"In the future `np.{attr}` will be defined as the "
    302         "corresponding NumPy scalar.", FutureWarning, stacklevel=2)
    304 if attr in __former_attrs__:
--> 305     raise AttributeError(__former_attrs__[attr])
    307 # Importing Tester requires importing all of UnitTest which is not a
    308 # cheap import Since it is mainly used in test suits, we lazy import it
    309 # here to save on the order of 10 ms of import time for most users
    310 #
    311 # The previous way Tester was imported also had a side effect of adding
    312 # the full `numpy.testing` namespace
    313 if attr == 'testing':

AttributeError: module 'numpy' has no attribute 'bool'.
`np.bool` was a deprecated alias for the builtin `bool`. To avoid this error in existing code, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Example fails

Hi,

First thank you for this package! When I ran the given example, I encountered the error "Negative capacity for lambda equal to -0.000000. Set roundNegativeCapacity to 1 if the value should be rounded to 0." I simply copy and paste the code here and run.

No cells identified

Hello,
thanks for writing this library. i am a newcomer in Ca imaging analysis. I used your library on 1 .avi file after after building the HNCCorr Movie() with the .avi file's data. But no cells are identified when HCCCorr.segment(movie) is called. What are some possible issues with the data or code leading to this?

On Direction of Feature Vectors: Rows or Columns?

Hi, I have a question regarding parameters s.percRows and s.percCols.
In function approximatePCA, the full correlation matrix (which should be symmetric) is downsampled to nRows x nCols (line 38), and then PCA analysis (line 41) is carried out with the each column treated as a variable (according to MATLAB document), and the resultant top nComps PCA coefficient vectors are used to get PCA scores for all pixels (line 45-47).
In this sense, each row of the downsampled correlation matrix is a "feature vector" of a corresponding pixel as mentioned in the eNeuro paper, or equivalently, pixels corresponding to those columns are the smaller-size reference set. So we should have nCols < nRows.

However, in the class definition file Solution.m, we see:
obj.percRows = 0.01;
obj.percCols = 1;
This seems to contradict the analysis above. Have I misundertood or missed something in the code?
Thank you!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.