hollie / device-plugwise-perl Goto Github PK

Do you plan to modify your program to provide an JSON output?
Thanks

During long-time testing the Stick stopped responding after receiving an error message and the software did not recover automatically.

Related message:
Sep 14 11:54:10 nessie be.lika.xpl-plugwise[88]: xPL::Dock->plugwise_process_response: Received response code with error: 000001C400E1
Sep 14 11:54:10 nessie be.lika.xpl-plugwise[88]: at /Library/Perl/5.12/xPL/IOHandler.pm line 213

To be examined, tested and fixed.

When connecting a Stick to a Plus device that has been reset (power reset sequence),
the 0011 return reply is shorter, resulting in Device::Plugwise refusing to talk to the stick, making it impossible use Device::Plugwise to send commands to set up a link.

On one Stick I get the following reply with a link:
RECV 0011 000D 000D6F00029008C4 01 01 9F0D6F00029C44B9 1D9F FF
And this reply without a link:
RECV 0011 001B 000D6F00029008C4 01 00

I suggest changing the pattern on line 333 of Device/Plugwise.pm as follows:

333c333
<         =~ /^0011([[:xdigit:]]{4})([[:xdigit:]]{16})([[:xdigit:]]{4})([[:xdigit:]]{16})([[:xdigit:]]{4})/

---
>         =~ /^0011([[:xdigit:]]{4})([[:xdigit:]]{16})([[:xdigit:]]{4})(?:([[:xdigit:]]{16})([[:xdigit:]]{4}))?/

This adds a "(?:" ... ")?" around the 2 last elements (network_key(16) & short_key(4))