If osu!HOPE is forcibly closed, the system proxy settings will not be cleared. This can possibly occur when osu!HOPE crashes, but consistently happens when the process is killed (for example in Visual Studio).

I'd want to add a second interface for plugins to implement, and the current plugin interface renamed. The interfaces should look like this:

1. IHopePluginMeta
   • void GetPluginMetadata(), like the previous version.
   • int GetHopeVersion(), returns the version of the osu!HOPE "api". This is to prevent breaking changes in the future to silently fail. For this to work, this interface should not be changed.
2. IHopeModule
   • void Load(), like the previous version.
   • void OnStart()
   • void OnStop()
   • void Unload(), to allow disposing of objects and threads. A bit of a design flaw in the current version.
   • void OnBanchoRequest(ref List<BanchoPacket>), like the previous version.
   • void OnBanchoResponse(ref List<BanchoPacket>), like the previous version.

This should get tweaked some more before implementing.

Plugins should be toggleable, especially since it comes with 4 examples plugins you most likely don't want to be enabled.

There's some bad and broken code in some of the plugins. I should fix that.

After fiddling around with the plugin interface I got to the following code:

using System.Collections.Generic;
using HOPEless.Bancho;
using HOPEless.Bancho.Objects;
using osu_HOPE.Plugin;

namespace Hope.Plugin.UserStatusRequest
{
    public class UserStatusRequestPlugin : IHopePlugin
    {
        public PluginMetadata GetMetadata()
        {
            return new PluginMetadata
            {
                Name = "UserStatusRequest",
                Author = "Node",
                ShortDescription = "requests user info without manually opening the users list",
                Version = "1.0"
            };
        }

        public void Load() { }

        public void OnBanchoRequest(ref List<BanchoPacket> plist) { }

        public void OnBanchoResponse(ref List<BanchoPacket> plist) {
            var requestedUsers = new BanchoIntList();
            requestedUsers.Value.Add(754565); // hard-coded value for testing
            plist.Add(
                new BanchoPacket(PacketType.ClientUserStatsRequest, requestedUsers)
            );
        }
    }
}

I used custom channel injection from Example2 as reference, however when trying to run it I get the following error:

Exception occured in plugin UserStatusRequest OnBanchoRequest: System.NullReferenceException: Object reference not set to an instance of an object.
   on Hope.Plugin.UserStatusRequest.UserStatusRequestPlugin.OnBanchoResponse(List`1& plist)
   on osu_HOPE.Program.<OnResponse>d__4.MoveNext() in C:\Users\Node\Documents\osu-HOPE\osu!HOPE\Program.cs:Line 124.