homalg-project / capandhomalg.jl Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 5.0 913 KB

The CAP and homalg projects compatibility package for Julia

License: GNU Lesser General Public License v3.0

Julia 88.25% GAP 4.36% Shell 7.39%

capandhomalg.jl's People

Contributors

Stargazers

Watchers

Forkers

mohamed-barakat herearound fingolfin zickgraf kamalsaleh

capandhomalg.jl's Issues

Provide a function which builds the documentations

ensure 4ti2 integration works even if user doesn't have lib4ti2_jll installed in global environment

See oscar-system/Singular.jl#236.

Compiled version auf Gauss not available

for three different reasons:

During installation, PackageManger only tries to compile packages if their availability is fail: https://github.com/gap-packages/PackageManager/blob/621b39c9e07f0ce7a91adfab66b48b6827ef1b6e/gap/PackageManager.gi#L859 One can call CompilePackage to manually trigger a compilation.
PackageManager by default installs to the directory ~/.julia/gaproot/v4.xx/pkg. So even if Gauss would be compiled, it would not be loaded because the pkg directory of "CapAndHomalg" is ordered before the above directory.
No recompilation takes place after UpdatePackageFromHomalgProject. So even when reordering the pkg directory of "CapAndHomalg" behind ~/.julia/gaproot/v4.xx/pkg, as soon as a version bump occurs the uncompiled version in the pkg directory of "CapAndHomalg" will be loaded again.

ensure Graphviz integration works even if user doesn't have Graphviz installed in global environment

"?CapAndHomalg" does not work

When using CapAndHomalg, the output says

Type: ?CapAndHomalg for more information

However, I get

julia> ?CapAndHomalg
ERROR: syntax: invalid identifier name "?"
Stacktrace:
 [1] top-level scope at none:1
 [2] run_repl(::REPL.AbstractREPL, ::Any) at /build/julia/src/julia-1.5.2/usr/share/julia/stdlib/v1.5/REPL/src/REPL.jl:288

Is this a misunderstanding on my part or a bug?

Tests failing on macOS

Last succeeding nightly run: https://github.com/homalg-project/CapAndHomalg.jl/actions/runs/2037461527/jobs/2940143455
First failing nightly run: https://github.com/homalg-project/CapAndHomalg.jl/actions/runs/2042961015/jobs/2950553263

Thus, if this was regressed by Julia the regressing commit should be one of the following: JuliaLang/julia@6ce817b...5dc6155

Of course the regression might also come from some package.

@mohamed-barakat If I remember correctly, you could reproduce this issue locally. Bisecting this to one of the four commits above might give further insights.

Is this repo following the SemVer standard (https://semver.org/)? If yes, my commit ebf5d3a should have bumped the minor version since it introduced a new feature (item 7. on https://semver.org/), and @kamalsaleh's commit 9dd2cbc should have caused a bump of the major version due to being a backwards incompatible change (item 8. on https://semver.org/).

Automatically install convenience methods for Julia lists

Currently, many packages contain special code for installing convenience methods for GAP operations which accept GAP lists to also accept Julia lists. Instead of doing this in every package separately, I propose that CapAndHomalg.jl should redirect InstallMethod (and InstallOtherMethod etc.) to a custom function which automatically installs such convenience methods in addition to the original GAP methods.

The GAP command Process hangs on macOS after loading Singular

DotToSVG hangs on macOS after loading Singular:

On macOS

$ julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.9.1 (2023-06-07)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using CapAndHomalg
CapAndHomalg v1.5.1
Imported OSCAR's components GAP and Singular_jll
Type: ?CapAndHomalg for more information

julia> LoadPackage( "RingsForHomalg" )

julia> DotToSVG( g"//dot\ndigraph empty{\n}\n" )
GAP: "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\"\n \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\">\n<!-- Generated by graphviz version 2.50.0 (20211204.2007)\n -->\n<!-- Title: empty Pages: 1 -->\n<svg width=\"8pt\" height=\"8pt\"\n viewBox=\"0.00 0.00 8.00 8.00\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">\n<g id=\"graph0\" class=\"graph\" transform=\"scale(1 1) rotate(0) translate(4 4)\">\n<title>empty</title>\n<polygon fill=\"white\" stroke=\"transparent\" points=\"-4,4 -4,-4 4,-4 4,4 -4,4\"/>\n</g>\n</svg>\n"

julia> HomalgFieldOfRationals( )
GAP: Q

julia> DotToSVG( g"//dot\ndigraph empty{\n}\n" )
GAP: "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\"\n \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\">\n<!-- Generated by graphviz version 2.50.0 (20211204.2007)\n -->\n<!-- Title: empty Pages: 1 -->\n<svg width=\"8pt\" height=\"8pt\"\n viewBox=\"0.00 0.00 8.00 8.00\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">\n<g id=\"graph0\" class=\"graph\" transform=\"scale(1 1) rotate(0) translate(4 4)\">\n<title>empty</title>\n<polygon fill=\"white\" stroke=\"transparent\" points=\"-4,4 -4,-4 4,-4 4,4 -4,4\"/>\n</g>\n</svg>\n"

julia> HomalgFieldOfRationalsInSingular( )
GAP: Q

julia> DotToSVG( g"//dot\ndigraph empty{\n}\n" )
<hangs>

On Ubuntu

$ julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.9.1 (2023-06-07)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using CapAndHomalg
CapAndHomalg v1.5.1
Imported OSCAR's components GAP and Singular_jll
Type: ?CapAndHomalg for more information

julia> LoadPackage( "RingsForHomalg" )

julia> HomalgFieldOfRationals( )
GAP: Q

julia> DotToSVG( g"//dot\ndigraph empty{\n}\n" )
GAP: "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\"\n \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\">\n<!-- Generated by graphviz version 2.50.0 (20211204.2007)\n -->\n<!-- Title: empty Pages: 1 -->\n<svg width=\"8pt\" height=\"8pt\"\n viewBox=\"0.00 0.00 8.00 8.00\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">\n<g id=\"graph0\" class=\"graph\" transform=\"scale(1 1) rotate(0) translate(4 4)\">\n<title>empty</title>\n<polygon fill=\"white\" stroke=\"transparent\" points=\"-4,4 -4,-4 4,-4 4,4 -4,4\"/>\n</g>\n</svg>\n"

julia> HomalgFieldOfRationalsInSingular( )
GAP: Q

julia> DotToSVG( g"//dot\ndigraph empty{\n}\n" )
GAP: "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n<!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\"\n \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\">\n<!-- Generated by graphviz version 2.50.0 (20211204.2007)\n -->\n<!-- Title: empty Pages: 1 -->\n<svg width=\"8pt\" height=\"8pt\"\n viewBox=\"0.00 0.00 8.00 8.00\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">\n<g id=\"graph0\" class=\"graph\" transform=\"scale(1 1) rotate(0) translate(4 4)\">\n<title>empty</title>\n<polygon fill=\"white\" stroke=\"transparent\" points=\"-4,4 -4,-4 4,-4 4,4 -4,4\"/>\n</g>\n</svg>\n"

julia>

GitHub Action workflows should be updated

The workflow runs display a warning:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.