homely / homely.aspnetcore.mvc.helpers Goto Github PK

Some helper methods, models and extensions for an ASP.NET Core MVC application.

License: MIT License

C# 100.00%

aspnet-core aspnet-core-2 aspnetcore csharp net netstandard netstandard20

homely.aspnetcore.mvc.helpers's Introduction

This is the home page / project overview for Homely.com.au open source projects.

At Homely, most of our development is done in private (with private repositories) but we do encourage to try and see if some of the code we do in our day-to-day work (which is used in our private systems) can be abstracted enough into a public project, for others to take advantage of.

We hope that other developers like yourself might find some of our efforts useful and/or enspiring!

Contributing

Discussions and pull requests are encouraged :) Please ask all general questions in this repository or pick a specialized repository for specific, targetted issues. We have a contributing document which goes into detail about how to do this.

Code of Conduct

Yep, we also have a code of conduct which applies to all repositories in the GitHub Homely.com.au organisation.

Languages currently supported

C# on .NET. Packages available on NuGet.

Feedback

Check out the contributing page to see the best places to log issues and start discussions.

homely.aspnetcore.mvc.helpers's People

Contributors

Stargazers

Watchers

Forkers

purekrome rpm1984 supermario-homely

homely.aspnetcore.mvc.helpers's Issues

Add NuGet

So we (and others!) can make use of this awesome sauce 😎

We'll need to setup one of those public NuGet org accounts.

Common HomeController

Have a common home controller that can be used and configured.

ability to set the 'banner'
ability to set this up in startup.cs so the banner can be configured. Also, helps with not having to rely on reflection for auto-finding the route.

Review and standardise the use of the ApiError / ErrorViewModel

Review the usage of the ApiError and ErrorViewModel and make sure they are both required and getting used in a standard way.

Was noticed when cleaning up #5

Missing implementation

I can't get AddProblemDetails() to work. Is this something not yet baked in or am i missing something?

Documentation about features

Need to document the modular features of this nuget package.

possibly link to an API template when that gets released.

Update Readme
Add wiki entries

More unit tests

Some more unit tests to check the MVP items.

Consider caching the Status Code json result.

Custom status code pages are going to write out the result as JSON in the ApiErrorResult schema/view.

Instead of serialising the same result on each request, consider using a ConcurrentDictionary and see if there's any perf gains.

Use perf tool to load test before/after.

Theory data in tests should include expected output

Currently we use theory data to control assertions, e.g here

This leads to some 'magic code' / checks, e.g:

if (id == 1)
{
    // some assertion
}

A better approach would be to setup the data in the controller/models via the tests (not hardcoded internally), and have the theory data include the expected model.

Then the assertions become a simple equality check on the JSON output.

Handle cancellation token errors.

When a request is 'cut' mid way before the response is fully sent AND the action method handled was an async action method, some crap is recorded in the log files.

I asked Andrew to help suggest something after providing some repo code, etc. and he blogged about it.

So implement this custom catch code.