honestbleeps / reddit-enhancement-suite Goto Github PK

See thread for explanation.

In the same vein as the night mode toggle.

Possibly allowing more granular filtering of NSFW content, eg using 3 radio buttons 'All', 'NSFW (only)' or 'SFW (only)'.

Requested. Pursuant to this post, amongst others.

http://redd.it/szhtb

Further information in this /r/enhancement thread: http://redd.it/mdebe

Confirmed 4.0.2 defect arising from reddit's change of css sprite.

actual username shows instead

When trying to save/unsave a submission in a multi-reddit (like http://www.reddit.com/r/gifs+gif) an error is shown saying that saving failed. This happens because the subreddit is posted alongside the other parameter if it is present, and, in case of a multi-reddit, reddit seems to choke on the "+" in it.
From my point of view, there is no need to post the subreddit when saving/unsaving, as the normal reddit function (with res disabled) doesn't do this.

For those with little horizontal space or a lot of subscriptions.

Add a link that points to www.reddit.com in the subreddit bar. Primarily for NER users who have the subreddit bar pinned.

Just happening on one of my computers at this time.

http://cl.ly/3n2z3N0E38261a223c3K

Dropdown subreddit manager displays duplicate entries. Not sure what troubleshooting information would be relevant here, so let me know.

Add mouseover popup to subreddit/domain name on link pages to be able to add that sub to filtered list.

Instead of following the mouse, if you go to fast resizing an image (or go widthwise on a long image), the mouse will escape and as soon as the mouse is off of the image, it stops resizing.

A fix is to have the mousemove function bind to the document or body elements instead of the image. I'm looking at the source now but it'll take me a while to make heads or tails of it.

Not booted into Linux right now, otherwise I would do it myself. Plain text looks, to be blunt, really ugly. GitHub has integrated Markdown parsing (many other types too, but most people use Markdown) anyways.

When I use the Inline Image Viewer to open several images/videos, only the first image link turns properly purple. All other links stay blue. After reloading the page, markVisited works again once with one image.

More of a feature request, but I think there are multiple subreddits where it would be useful to have an image move down the page as a user worked their way through comments.

It would be nice if RES added a live display of the number of characters typed in the Title section of a new submission, so it's easy to tell how close you are to the 300 character limit.

http://redd.it/o47yq

Using link, quote, code, bullets, numbers, ಠ_ಠ or promote, results in a loss of focus in Chrome but not Firefox. Opera/Safari untested.

Using a looping document.activeElement in the console, it seems Chrome loses focus to the body, while Firefox loses focus entirely (?).

In Chrome this means that shortcuts (F, shift-F etc) become active unless the user explicitly clicks back into the textarea.

I was able to negate this by adding targetTextArea.focus() at the end of the refreshPreview function, but whether this will have a negative performance impact, I have no idea.

Didn't want to post a patch up as you can decide for yourself how to work around it. Pursuant to this thread and a few similar ones, I had a look into why it was working on some and not others.

I think it's to do with the subreddit name being sent to the filterDomain function (~13039) not being converted to lowercase, either from postSubreddit or using RESUtils.currentSubreddit(). When this then gets passed to arrayContainsSubstring as reddit and is compared to applyList, it breaks on subreddits with any capitalization. I only realised when I learned that indexOf is case sensitive.

Usual form - if this is off base then quietly burn the evidence.

Redditor AbuMaia submitted http://www.reddit.com/r/Enhancement/comments/mmibx/bug_clicking_unread_message_count_instead_of/

Line 6870 of reddit_enhancement_suite.user.js of 4.0.2 is

this.mailCount.setAttribute('href','/message/unread');

changing it to

this.mailCount.setAttribute('href','/message/unread/');

fixes the issue.

(I know there has to be a better way to tell you but I haven't the slightest clue)

If you scroll down through a list of links using the 'J' key, the page doesn't scroll down enough to activate never ending reddit.

You can scroll down using shift+J as long as you are not already at the bottom of the page (not an ideal workaround!)

This has been tested and proven to occur in production versions of Chrome, Safari and Firefox. Presumed to occur in Opera as well.

Most users don't comment right away when opening the comments. It would be nice to have the option to collapse/hide the
user comment text box (usertext.cloneable) and/or to move it to the bottom.

Reddit has updated their markdown handler...

Of note: the handler now automatically turns /r/something into a link, something that RES 4.0 did.

This needs to be changed to /r/resissues please

I've seen a few guys post wall-o-text error messages like the one in here... ignored most of it not realizing it was SnuOwnd until I looked more closely.. I figured with all the minified stuff it was probably jquery or a plugin or something...

http://www.reddit.com/r/Enhancement/comments/t0w3z/bug_customized_subreddit_manager_displays_default

http://code.reddit.com/wiki

Opera 11.61 on linux

When you are browsing a users profile on Firefox if you refresh and you have gone down a few pages it shows your front page.

Example:
http://www.reddit.com/user/Doritos_Man#page=2

After editing a comment, then saving it, your 'real' name is revealed.

See here for original bug report.

Seems the div that DOMNodeInserted captures is the child of the comment that was just edited, not the edited comment itself. If no child comment(s) exist, then no div is inserted, so the event is never triggered.

Now that we have a spam button on link listings for moderators, there are two buttons labeled as spam. I think we need to come up with either a different wording or a way to differentiate it from the reddit button.

http://redd.it/rt8mh

RES Version: 4.0.3
Browser: Chrome
Browser Version: 18
Cookies Enabled: true
Platform: Windows
I often use the https://pay.reddit.com site to allow for partial encryption of data, at least to remain private from my ISP or employer being able to intercept. However, when RES is enabled, I can't use the save or hide buttons. I get the error "Error caught: JSON parse failure on the following data:" and an OK button. If I disable the RES plugin the buttons work fine.

No errors in the error console, but the following log line is generated:

there is already an alert open. break out. chrome-extension://kbmfpngjjgdllneeigpgjifpgocmfgmb/reddit_enhancement_suite.user.js:1866

(this is when clicking save)

http://redd.it/t0rxt

The [M] and [F] buttons open all images, not just the specified M/F posts.

This thread reminded me about it, but it's not the original thread: http://redd.it/mixqo

There are some URLs in a post I made that are not parsed correctly as URLs:

As seen on the screenshot, the last URL is parsed correctly.

here is the full input. I'm not sure, but this might be related to the line wrapping.

RES 4.0.3
Chrome 18

While writing a comment with the live preview on, if I insert a < and another character after it, those characters and rest of the line do not appear in the live preview.

Example:

noremap <C-c> Esc

appears as

noremap

Offending line is here: https://github.com/honestbleeps/Reddit-Enhancement-Suite/blob/master/lib/reddit_enhancement_suite.user.js#L10230

Any link to an eho.st .gif is changed to be .jpg, resulting in broken image expansions and even broken click destinations.

There should be an option to have links opened with Shift + Enter open in the background, instead of switching to them right away, alá http://www.reddit.com/r/Enhancement/comments/n8cv6/how_to_open_links_in_new_background_tabs/c374mbu

It looks in 'href' instead of 'srcurl' so the expandos never get created. Even changing that doesn't convert all DA links into expandos, and only some for 'fav.me' (though these invariably don't contain an image).

I just put the edits into a diff rather than pollute the main code as it probably needs other additions.

I have my RES set to have the userbar and subredditbar stickied at the top of my window. In opera (11.60), when I'm scrolled down the page a bit, clicking the arrow on the user-switcher makes makes the dropdown open up floating, down the page.

http://i.imgur.com/fYzmy.png

http://redd.it/o3ge8

In Opera, when Never Ending Reddit's go method is called sessionStorage will often not have been instantiated yet, causing the extension to fail to load completely.

It does handle it in specific cases like \* but it is not universal. For example, \> will yield \> in the output instead of \.

The correct output would be > not \>

I can't find the comment thread that discusses it, but I believe hb said he would add it to the work stack. Currently one can remove the counter from the orangered, but this doesn't affect the counter in the title bar.

If you go to a permalink of a comment, the comment navigator stuff appears at the top of the screen, even if you have comment navigator turned on, but the 'show by default' setting set to 'off' in your RES settings.

A random permalink to show you: http://www.reddit.com/r/Enhancement/comments/rcheo/getting_res_error_click_it_and_it_tells_me_to_set/c476mma

The comments thread itself: http://www.reddit.com/r/Enhancement/comments/rcheo/getting_res_error_click_it_and_it_tells_me_to_set/

I'm sorry if this has been discussed before.

I don't think most people like it. The way I see it, it is a little irritating because you might want to see the image where it's located even though it's a duplicate. It is useful though in that you can know it's a duplicate before you even open it, but this could also be achieved by a small notice by the button saying [dublicate], and then you could open the image well knowing that you'd seen it before.

So I think that option should be disabled by default. But that's only my opinion.

People are having trouble using account switcher to log in when using incognito mode in Chrome.

(Incidentally: would be worth checking to see if this is what's breaking "Hide" and "save" links for some people, too)

http://www.reddit.com/r/kindle/comments/ri0u2/thanks_for_filling_out_my_survey_rkindle_thought/

The dropbox url http://dl.dropbox.com/u/2193674/aggregated-data.htm

with link text "Demographic and Behaviour Aggregate Results"

is converted to http://www.reddit.com/user/Demographic%20and%20Behaviour%20Aggregate%20Results

Coords should be -16px -521px currently they are 0px -22px.

• RES Version: 4.0.3
• Browser: Chrome
• Browser Version: 16
• Cookies Enabled: true
• Platform: Mac

When trying to report this user as a spammer: http://www.reddit.com/user/tfotilessydney
the spam link fails to work and the following error appears in my javascript console.

Uncaught TypeError: Cannot read property 'href' of null
modules.spamButton.reportPost

I'm guessing the problem is caused by the fact that the spammer hasn't made any posts before, just one comment.

Didn't want to post this on /r/enhancement because I didn't want to highlight the sample spammer too much.

http://redd.it/nqi3l