horst-n / croppableimage3 Goto Github PK

For my client it would be perfect if the uncropped source image could either be replaced entirely by a cropped version, or if the original version would be "downgraded" to an image variant.

I know that this sounds silly at first, but:

• If my client drops Photoshop from their toolchain entirely, the uncropped images from the digital camera are all over the place in the PW backend (preview thumbs, image picker …)
• We defined an aspect ratio of 3:2 for all images that are uploaded. There may be other formats, but 3:2 for all images are mandatory.
• It would be cool if I could define 3:2 as "standard crop preset". As soon as the image gets cropped, the new "original" image would be that cropped version.
• All image previews in PW backend would now use the manually (or automatically) cropped version.

This would motivate my client to do more careful cropping within PW and would reduce the need for Photoshop.

Does this make any sense?

CroppableImage3 version: 0.9.17
Processwire version: 3.0.42

If I name my crop setting in camel case: cropSetting,600,600 then the thumbnail that gets generated for the 600x600 size when i upload an image will have a name that ends with "....cropSetting.jpg"

This creates an invalid URL in the front-end, because this:
$page->mycroppableImagefield->getCrop('cropSetting')->url
outputs an URL ending with "....cropsetting.jpg" (all lowercase), while the actual file still has an Uppercase in its name.

If I go back and manually select the area to crop for that file on the "cropSetting" setting, then another file variation gets generated, this time ending with "....cropsetting.jpg" (all lowercase) and the URL will finally work.

We've found with a couple of websites that when you go back into an already cropped image and set a new crop - the old crop remains in cache.

This then results in the old crop being served up.

To recreate:

1. Set a new crop settings in the field settings. E.g "crop_image,1440,300,template_name"
2. Upload an image and crop
3. Go to the page in question on the front-end
4. Go back to that page's admin screen and set a new crop
5. See that it hasn't changed on the front-end

I have a running website with standard image fields, which I want to switch to CroppableImage3.

Problem is, I use the module "Image Extra" http://modules.processwire.com/modules/image-extra/ This provides some custom extra columns in the database. see here:

When I’m switching this field to CroppableImage3, the extra columns in the database are gone. Not cool, although I understand why, of course. Is there a chance that you keep all unknown extra columns in the database when changing the field type from image to croppableimage?

Happy X-Mas and keep up the good work!

I see a PHP notice while cropping images from a cropableimagefield located in a repeater-matrix item:

PHP Notice: Only variables should be passed by reference in .../ProcessCroppableImage3.module:67
$pages_id = (int) end((explode("_repeater", $field)));

…as I understand, one should pass a variable to end() - this fixed it for me:

$rppage_array = explode("_repeater", $field); $pages_id = (int) end($rppage_array);

ProcessWire: 3.0.165
PHP: 7.3 & 7.4

Deprecated: Array and string offset access syntax with curly braces is deprecated in C:\inetpub\wwwroot\site\modules\CroppableImage3\classes\CroppableImage3Helpers.class.php on line 280, 281 and 284

https://wiki.php.net/rfc/deprecate_curly_braces_array_access

I have the latest PW3 dev and CroppableImage 3 and see a warning:

Fehlerhafte Modul-Abhängigkeit: InputfieldCroppableImage3 benötigt FieldtypeCroppableImage2

Since the last update from friday night, I get on specific image fields the following Notice:

Notice: Only variables should be passed by reference in "site/modules/CroppableImage3/ProcessCroppableImage3/ProcessCroppableImage3.module" on line 65

The cropping works as expected, but the frontend output won't work anymore. The getCrop method seems not to deliver an object anymore!

Due to my first investigations in only occurs on multi-image fields.

I upgraded an older version of PW to 3.0.x and in the process upgraded all the associated modules including CroppableImage to CroppableImage3 but somewhere along the way from moving the site from dev to live something has gone wrong because now there are problems uploading images. Sometimes they'll upload and sometimes when you click on the Choose File button, or drag an image into the field, nothing happens.

On a test page that already had an image in it, I couldn't get another one to load and there were no errors in the console. After removing the one image and resaving, neither the choose file button or dragging were working. Clicking the choose file button produced no errors, but dragging returned:

Uncaught TypeError: can't access property "grid", config.CroppableImage is undefined
/site/modules/CroppableImage/InputfieldCroppableImage/InputfieldCroppableImage.js?v=83-1429629453:405
jQuery 7
/site/modules/CroppableImage/InputfieldCroppableImage/InputfieldCroppableImage.js?v=83-1429629453:403
jQuery 11

from InputfieldCroppableImage.js:405:21

I've also just updated to 1.2.0 but the problem still remains. Any idea what I can do to fix it?

After upgrading to PW 3.0.142 both front and back end fail to load with:

Cannot make non static method ProcessWire\FieldtypeFile::getModuleConfigInputfields() static in class ProcessWire\FieldtypeCroppableImage3 (line 4 of /site/modules/CroppableImage3/FieldtypeCroppableImage3/FieldtypeCroppableImage3.module)

Renaming the module folder brings the admin back but I'm then unable to change the fieldtype of fields using FieldtypeCroppableImage3. When editing the field, the dropdown is showing as blank and if I choose a different option and then resave, it comes up blank again.

We experience a problem with Croppable3 within a RepeaterMatrix field. While the first crops are created successfully, every attempt to adjust the image will fail. There is a problem with the JQuery module. I am not sure if it's a problem with the RepeaterMatrix field way to deal with the DOM or the Croppable3 module itself.

So, the crops seem to work...

Then when accepting it, I receive this error in the console.

And the new crop is not saved at all...

Title says it all - it's an easy fix :)