Giter VIP home page Giter VIP logo

depixelization's People

Contributors

hoshiningen avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

brewman29

depixelization's Issues

Simplify the Source Directory Structure

The way the source directory structure is set up currently is redundant. I have a source/<project>/<source|include> hierarchy currently, in which the source and header files are segregated. I'd like to combine the relevant source and header files into the same directory and simplify the source directory structures overall.

Acceptance Criteria

  • Source directory structure is simplified and the CMake scripts are updated

Setup packaging

Configure the project so that it can be bundled up as a package that can be installed. Packaging and installation needs to work cross-platform.

Acceptance Criteria:

  • Packaging is setup properly for the project
  • The project can be installed via cmake --install
  • Works cross-platform

Create a lattice graph based on the images pixel data

I need to be able to read in a bitmap and create an 8-connected lattice graph based on the image dimensions. This story also has time baked into it for setting up the project and pulling in the correct libraries.

depixelization/source/utility/public/FileUtil.h:49:21: error: 'transform_reduce' is not a member of 'std'

I run the code on Ubuntu 18.04 , cmake version 3.18.2, boost 1.72.0, GCC 8.2.0.

when I run cmake --build .

Like the Title, it throw me a Error message:

depixelization/source/utility/public/FileUtil.h:49:21: error: 'transform_reduce' is not a member of 'std' return std::transform_reduce(std::cbegin(value), std::cend(value), std::string{}, std::plus<std::string>{},

and

depixelization/source/utility/public/FileUtil.h:59:25: error: no match for 'operator==' (operand types are 'const std::__cxx11::basic_string<char>' and 'void') return item == toLower(filePath.extension().string());
thank you very much!

Investigate and Fix Performance Bottlenecks

There are portions of the algorithm that run slow as the size of the image increases. It gets to the point were at reasonably large images (100px by 100px, or so) that the performance becomes unbearably slow.

Investigate the less performant portions of the algorithm and develop solutions to address those issues.

Acceptance Criteria

  • The performance bottlenecks have been found
  • A solution to address them has been decided on
  • The solution has been implemented, and metrics have been recorded to compare against the less performant version
  • A noticeable difference is measurable. The processing times are reasonably quick for the expected-size images (300px by 300px max)

Implement Argument Parsing

It's difficult to use the application in its current form. To output anything, it has to be done programmatically with calls to internal API. The application is intended to be a CLI, so what better time than now to get that configured.

Acceptance Criteria

  • Application can be built and interacted with via a CLI

Setup CI/CD Pipeline

I need a way to verify that the project builds cross-platform, with a variety of compilers. Get a CI/CD system setup that is triggered on pull request.

Acceptance Criteria

  • Causes a build to kick off against a build matrix
  • Unit tests need to run
  • Checks need to be added so that the build and tests pass before a pull request can be merged

Hide internal features from the public api

The similarity graph, and possibly other pieces of the public API, expose internal calls that should not be accessible. These are not linked publically and will cause linker/compilation errors if one tries to use them.

Setup Contribution Guidelines

Prepare the repo to accept contributors. Need to research the methods that people would be contributing (forks vs. adding contributors to a repo). I don't want code reviews to be focused on coding style, formatting, or other things that tools can enforce already.

Acceptance Criteria:

  • Create contribution guidelines
  • Setup a clang-format file

Support const graph methods

The similarity and voronoi graphs both use an inherited implementation class to hide the implementation details from the compiler. The way this was implemented, it can't support having constant methods in the public API of the class that inherits from the implementation class.

This is not ideal, as external methods can't accept const types with that implementation class. They have to take them by value or by reference.

void Render(SimilarityGraph& simGraph)
{
   // This would be better if simGraph was constant because otherwise, it's able to modify the graph, and passing by value is expensive
}

Acceptance Criteria:

  • The implementation class that the Similarity and Voronoi Graphs use has been modified to allow constant operations

Does not compile: no declaration matches ArrayToTuple

Hi!

I've tried building this, and got a compile error (GCC 8.2.1):

[  3%] Building CXX object source/reshaper/source/private/CMakeFiles/reshaper-impl.dir/ImageView.cpp.o
In file included from Depixelization/source/reshaper/source/private/ImageView.cpp:1:
Depixelization/source/reshaper/include/private/ImageView.h:220:6: error: no declaration matches ‘auto dpa::image::internal::ImageView<Channels, BitDepth>::ArrayToTuple(const std::array<BitDepth, channel_count_v<Channels> >&) const’
 auto ImageView<Channels, BitDepth>::ArrayToTuple(const std::array<BitDepth, channel_count_v<Channels>>& array) const noexcept
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/ImageView.h:46:10: note: candidate is: ‘template<template<class> class Channels, class BitDepth> template<class Indices> auto dpa::image::internal::ImageView<Channels, BitDepth>::ArrayToTuple(const std::array<BitDepth, channel_count_v<Channels> >&) const’
     auto ArrayToTuple(const std::array<BitDepth, channel_count_v<Channels>> & array) const noexcept;
          ^~~~~~~~~~~~
source/reshaper/include/private/ImageView.h:21:7: note: ‘class dpa::image::internal::ImageView<Channels, BitDepth>’ defined here
 class ImageView final
       ^~~~~~~~~

This error is pretty challenging to digest, even to people calling themselves C++ programmers.

If that matters: I use cmake 3.15.5. Oh, indeed, here's also an output from [relatively old] Clang 7.0.1:

In file included from Depixelization/source/reshaper/source/private/ImageView.cpp:1:
In file included from Depixelization/source/reshaper/include/private/ImageView.h:3:
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:70:22: error: template template argument has different template parameters than its
      corresponding template template parameter
struct channel_count<Y>
                     ^
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:44:1: note: too many template parameters in template template argument
template<typename BitDepth, typename = EnableIfSTBBitDepth<BitDepth>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:59:10: note: previous template template parameter is here
template<template<typename> class Channels>
         ^~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:76:22: error: template template argument has different template parameters than its
      corresponding template template parameter
struct channel_count<YA>
                     ^
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:47:1: note: too many template parameters in template template argument
template<typename BitDepth, typename = EnableIfSTBBitDepth<BitDepth>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:59:10: note: previous template template parameter is here
template<template<typename> class Channels>
         ^~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:82:22: error: template template argument has different template parameters than its
      corresponding template template parameter
struct channel_count<RGB>
                     ^
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:50:1: note: too many template parameters in template template argument
template<typename BitDepth, typename = EnableIfSTBBitDepth<BitDepth>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:59:10: note: previous template template parameter is here
template<template<typename> class Channels>
         ^~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:88:22: error: template template argument has different template parameters than its
      corresponding template template parameter
struct channel_count<YCbCr>
                     ^
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:53:1: note: too many template parameters in template template argument
template<typename BitDepth, typename = EnableIfSTBBitDepth<BitDepth>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:59:10: note: previous template template parameter is here
template<template<typename> class Channels>
         ^~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:94:22: error: template template argument has different template parameters than its
      corresponding template template parameter
struct channel_count<RGBA>
                     ^
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:56:1: note: too many template parameters in template template argument
template<typename BitDepth, typename = EnableIfSTBBitDepth<BitDepth>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Depixelization/source/reshaper/include/private/../reshaper/Pixel.h:59:10: note: previous template template parameter is here
template<template<typename> class Channels>
         ^~~~~~~~~~~~~~~~~~
5 errors generated.

Can you fix this?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.