Comments (9)
@jglovier I suppose we could. The couch part would be different depending on OS. We could at the very least have a script that tests to see if couch is up before running ember serve.
from hospitalrun-frontend.
Yeah, even if it just triggered ember serve
, it would benefit those familiar with the script/server
convention by standardizing the approach. If more things were required, it could also output a warning like Be sure to run Couch.app
, etc.
from hospitalrun-frontend.
I like the idea.
I am also very fan of Makefile
s and I can open a PR for that if people think it is valuable and are comfortable using make
.
from hospitalrun-frontend.
@filipesperandio I don't think we need a Makefile since there aren't any executables for this project that get built. It's an ember web app and the way it gets built is via ember build
.
from hospitalrun-frontend.
I understand that. make
helped me in the past even on script projects smoothing out dependencies.
for example a target make serve
could depend on ember-cli
and bower
being installed.
from hospitalrun-frontend.
@jglovier script/server
OR scripts/server
? (with an s
at the end of scripts)
from hospitalrun-frontend.
@filipesperandio gotcha. Thanks for clarifying.
from hospitalrun-frontend.
@filipesperandio I prefer script/server
but probably just because it is a convention we use at GitHub. Also, it mentally makes sense when you are running any one given script at a time. I.e. mentally I think "I'm going to run the server script" so it's semantically consistent from that perspective. But it's probably not that big a deal LOL.
from hospitalrun-frontend.
Cool, I will adjust.
On Feb 5, 2016 7:01 PM, "Joel Glovier" [email protected] wrote:
@filipesperandio https://github.com/filipesperandio I prefer
script/server but probably just because it is a convention we use at
GitHub http://githubengineering.com/scripts-to-rule-them-all/.—
Reply to this email directly or view it on GitHub
#11 (comment)
.
from hospitalrun-frontend.
Related Issues (20)
- Imaging Request - requestedBy should store the currently logged in user id HOT 7
- Duplicate Patient Modal cannot be triggered HOT 10
- ReportIncident save button always rendered HOT 8
- shortid is deprecated HOT 6
- Lab - In the Request Lab routine make the visit field required HOT 5
- New Imaging Request - required visit not enforced HOT 7
- New Lab Request - required visit not enforced HOT 2
- Focus of menu item "Visits" disappears when I view the details HOT 2
- ViewAppointments Tests Have a Console Error HOT 4
- Test patients/care-goals/CareGoalTab.test.tsx on MacOS runner fails HOT 4
- Lack of Visible Focus - WCAG Success Criterion 2.4.7
- NewLabRequest.test.tsx is flaky HOT 4
- Creating new patient - validation of the phone number is wrong HOT 1
- Creating new patient - validation messages not appropriate HOT 5
- Cancel Button HOT 5
- Update Portuguese translation HOT 8
- Type 'unknown' is not assignable to type '(prevState: ImagingRequestError | undefined) => ImagingRequestError | undefined'.
- Live demo is not working.
- Imrpove UI in sidebar HOT 11
- Error occur in while install and run Hospital Run Frontend HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hospitalrun-frontend.