hpi-swa / metacello-git Goto Github PK

OSProcess is, at least on Windows, obviously required to use metacello-git. But it was missing in my image today, when I wanted to use metacello-git for the first time. Thus, I assume it is missing in the dependencies.

The usual copy-n-paste-ready Metacello new ... load stanza should be added in the readme, if applicable.

We should revise the wording for messages in this project. For example, "hardcore cloning action" seems weird to me. :)

Weird. All my Git repository entries were gone after I renamed the image folder... AND I had to re-enter my author initials of course...

A debugger with the following stack trace opens when I want to browse the 'Metacello' preference category. Thus, the category is currently inaccessible.

SubclassResponsibility: My MCGitBasedNetworkRepository class subclass should have overridden basicDescription
MCGitBasedNetworkRepository class(Object)>>subclassResponsibility
MCGitBasedNetworkRepository class>>basicDescription
MCGitBasedNetworkRepository class>>defaultCacheDirectory
MCGitBasedNetworkRepository class>>cacheDirectory
MCGitBasedNetworkRepository class>>cacheDirectoryPath
PragmaPreference>>preferenceValue
PBTextPreferenceView>>preferenceValue
PluggableTextMorph>>getText
PluggableTextMorph>>on:text:accept:readSelection:menu:
PluggableTextMorph class>>on:text:accept:readSelection:menu:
PluggableTextMorph class>>on:text:accept:
PBTextPreferenceView>>textField
PBTextPreferenceView>>representativeButtonWithColor:inPanel:
PBPreferenceButtonMorph>>preferenceMorphicView
PBPreferenceButtonMorph>>initializeWithPreference:model:
PBPreferenceButtonMorph class>>preference:model:
PreferenceBrowserMorph>>newPreferenceButtonFor:
[] in PreferenceBrowserMorph>>newPreferenceListInnerPanel
SortedCollection(OrderedCollection)>>do:
PreferenceBrowserMorph>>newPreferenceListInnerPanel

MCRemoteGitRepository class>>clone crashes due to an empty uri when cancelling the following dialog:

Currently, repository is the default name of the subfolder containing the filetree data. It has been configurable per-image since 3e48b4. Now, my teammate has created a project with packages as that subfolder (he is not using metacello-git) and I would not like to be out-of-luck if I want to work on two projects with different names for that folder.

Many projects seem to use repository, including dalehenrich/metacello-work, but, for example, hpi-swa/Ohm-S also uses packages.

If your local git repo is behind the remote repo, the "save" in Monticello will perform the commit, but fail the push action. A GitError is displayed.
After pulling the changes, you can only push your changes manually (via command line), because Monticello thinks there are no changes.

Currently the developer has to initialize a filetree repo in a directory and then add a git repository and its remote by hand. Its not possible to add on Git repository without a remote in Squeak

see MCGithubRepository

I think there is something wrong with the mapping of Metacello comments to command line parameters. This comment causes and infinite loop of OS-calls during commit phase:

UPD: improved controls in script editors (top-right corner)
NEW: limit connection to query-change notifier to a tree depth of 5. Should speedup things especially for deep recursive tree structures and their cleanup
NEW: skip script interpretation with the property "#hidden -> true." (avoids inconvenient comment-out or script-part removal)

Maybe it's the " ? Do we escape that?

The use case of MCGitRepository is a bit confusing. It tries to pull when opening the repository in Monticello which is not possible for a local repository without remotes.

The code is found in MCGitRepository's refresh method:
https://github.com/JumpIntoSqueak/metacello-git/blob/master/repository/Metacello-Git.package/MCGitRepository.class/instance/refresh.st#L7

I would suggest to either just change the behavior of MCGitRepository so that it really deals with local only repositories or to add another class MCLocalGitRepository for that use case.

The path to the local repository folder is stored as an absolute file path (like package-cache etc.).
After moving the image folder, it cannot be found. Changing the path via "edit repository info" is not working.
Idea: Store the path relative to the image or relative to the "package-cache"-folder

like metacello-work