`SmalltalkCI-*` used in package pattern for Pharo does not match any packages - it should about smalltalkci HOT 6 CLOSED

I'm a little confused here. Is this a smalltalkCI bug or a Pharo problem?

from smalltalkci.

Well, the bug is in the behavior of SmalltalkCI ... a pattern that is used for category matching (Smaltalk-*) by SmalltalkCI gives a different result when used to match packages in the Pharo/GemStone #package extension for SmalltalkCI ... and the fix will most likely be made in SmalltalkCI-Pharo.st so technically this is a SmalltalkCI bug ...

At the end of the day Smaltalk-* interpreted as regex (which is what Pharo currently does for packages) does not give the same result as SmalltalkCI>>classesInCategoryPrefix: (which is what is used by Squeak, Pharo and GemStone for categories) ....

from smalltalkci.

This bug is illustrated by these two expected failure conditions:

expectedFailures
  SmalltalkCI platformSymbol = #'pharo'
    ifTrue: [ ^ #(#'testGemStonePharoClassesTestPackages2') ].
  SmalltalkCI platformSymbol = #'gemstone'
    ifTrue: [ ^ #(#'testGemStonePharoClassesTestPackages3') ].
  ^ #()

The test code will be present on the master branch once PR #74 is merged

from smalltalkci.

Once the merge is complete @estebanlm and I can discuss alternatives, as I think the behavior should be consistent

from smalltalkci.

sorry for not having time recently to look at this :(
but yes, the "" pattern should match for pharo (also, the regex "." should do it)...

from smalltalkci.

We have unified this across all dialects with 5073e62. Here is an example.

from smalltalkci.