Giter VIP home page Giter VIP logo

Comments (9)

peteruhnak avatar peteruhnak commented on May 24, 2024

Nevermind, apparently the second variant doesn't work (even though the array syntax would suggest otherwise.)

from smalltalkci.

fniephaus avatar fniephaus commented on May 24, 2024

The #testing section currently works as follows:

  1. If not set, determine tests to run automatically (just like builderCI)
  2. If #classes or #categories are set, use these for testing and ignore everything else
  3. If #include or #exclude are set, determine tests to run automatically and add or remove tests accordingly. Note that 2. should not be the case (#classes and #categories should not be set).

I hope the above makes sense.

from smalltalkci.

fniephaus avatar fniephaus commented on May 24, 2024

If you have an idea how to improve the doc, please send a PR πŸ˜ƒ

from smalltalkci.

peteruhnak avatar peteruhnak commented on May 24, 2024

My point was different:

if I have

#packages : [ 'Foo.*' ]

then Foo is tested as expected ( https://travis-ci.org/peteruhnak/ci-foo/builds/109091321 )

however if I have

#packages : [ 'Foo.*', 'Bar.*' ]

then only Foo is tested, and not Bar ( https://travis-ci.org/peteruhnak/ci-foo/builds/109091408 )

So I have to do

#packages : [ 'Foo.*' ]
#include: {
  #packages : [ 'Bar.*' ]
}

to have them tested both ( https://travis-ci.org/peteruhnak/ci-foo/builds/109091536 )

So my question is: why does the second variant not work?

My impression is that the first #packages is based on LoadSpecs and ignores what I actually write there (because it will test also tests from different packages that are part of the project but do not match the regex).

from smalltalkci.

peteruhnak avatar peteruhnak commented on May 24, 2024

Just to confirm, are my observations about the default package: not really having effect correct? (i.e. that they will use LoadSpecs regardless of what I put there.)

from smalltalkci.

fniephaus avatar fniephaus commented on May 24, 2024

Sorry for leaving this unanswered for so long.
I understand that

#packages : [ 'Foo.*', 'Bar.*' ]

only causes Foo to be tested and not Bar? Is this the current behavior? If so, it's a bug.

from smalltalkci.

peteruhnak avatar peteruhnak commented on May 24, 2024

That was the case as you can see in the linked travis builds.

I seem to have deleted the github repos, but it should be easy to setup again…

from smalltalkci.

fniephaus avatar fniephaus commented on May 24, 2024

That's my bad I guess. But yes, shouldn't be to hard :) I'll look into it in the next few days.

from smalltalkci.

fniephaus avatar fniephaus commented on May 24, 2024

@peteruhnak you were absolutely right, explicit #packages have been disregarded completely. A fix should be very simple...

from smalltalkci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.