Make sure smalltalkCI fails if any subcommand fails about smalltalkci HOT 5 CLOSED

@dalehenrich I have not been able to reproduce the problem you mentioned in #51 (comment).
Regardless, I have enabled a few more safety switches to make sure smalltalkCI fails as soon as something unexpected happens.

from smalltalkci.

@dalehenrich Do you think it's necessary to keep these exit 1s or the print_error_and_exits?

from smalltalkci.

I think that those exit 1s were created before I knew that print-error_and_exit existed :)

from smalltalkci.

I see that you've assigned this bug to me ... what do you want done in relation to this ... change the exit 1s or something else?

from smalltalkci.

I had a look at this again.
Looks like that this || status=$? causes the problems. Basically set -e is ignored for some reason when a subfunction is called like that. I'm cleaning up the code a little bit and I'll make sure checks like this are only used when absolutely necessary.

from smalltalkci.