Giter VIP home page Giter VIP logo

toha's People

Contributors

alteholz avatar bernatbc avatar blueyetisoftware-jason avatar chow-ray avatar chronikom avatar chutommy avatar davidgs avatar dependabot[bot] avatar donfiguerres avatar eishundo avatar emily-0616 avatar functionalhacker avatar gabrieljean avatar github-actions[bot] avatar hossainemruz avatar imgbot[bot] avatar jbleduigou avatar kaligule avatar lgatellier avatar lna-dev avatar marionmoseby avatar nirzak avatar noritakaizumi avatar ormissia avatar rihoj avatar roxedus avatar srnetochan avatar stueja avatar trepix avatar vlebert avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

toha's Issues

Single Post avatar override not working

From what i can tell the avatar for individual posts is not being configured properly. I provided an asset url like such https://github.com/alex-bezek/blog/blob/master/data/en/author.yaml#L6 which worked for changing the main landing page's avatar, however individual posts avatars didn't update. I got around this by overriding the template and specifying my only locale https://github.com/alex-bezek/blog/blob/master/layouts/partials/helpers/get-author-image.html#L5

TOC in post page

@hossainemruz I really like your website template and I used a slightly edited version of your design for my blog. Thank you very much for the great work!

Recently I have seen that you have changed the toha.netlify.app and I very much liked the implementation of toc on the posts page. So, I tried to clone your repository toha-example-site to see the change in code. Everything seems to work fine, but on the posts page, the sidebar, post and toc are misaligned. The sidelist on the left, them the post begins after the sidelist ends, and after that the toc shows up at the very end, even though the website on toha.netlify.app works fine. I do not know why.

I have also spent some time to edit the files to my liking, so I would not want to change it to your new organisational structure of config files as it would be a huge work. I just wanted to ask you if you could maybe provide the code additions to get the toc in the single.html without the sidebar. It would be very helpful, thanks!

Language attribute

As a user in other countries,i think language attribute set by hugo variables will much better.

Add Contact Form functionality

It would be nice to have the option to include a contact form, allowing the form action to be whatever forms provider the user chooses like Netlify, Typeform, etc...

Posts Page Frontmatter and Configuration

I was looking through your documentation to understand how to set up posts but the post for that tutorial is not completed. Could you provide quick details on how to populate that page, please?

Footer does not route properly from posts page

Hello,

I noticed that when working with this theme, if you go to the posts page and click any of the navigation on the footer that it is not working correctly. I experienced this both using a local build and it exists on the example website as well.

From the posts page if you want to click on experiences, it will route to https://toha.netlify.app/posts/#experiences rather than (what I assume is expected) https://toha.netlify.app/#experiences.

Screenshot_20200714_205234

I think the fix may just be a slight adjustment to your footer.html. If you agree that this is a bug, If I find some spare time to take a look and find and a good solution would you want me to create a pull request or is this something you'd prefer to look at and fix yourself?

Author image stretched

Description

The author image is being stretched instead of being fitted in the circle by the middle point, which is what I'd expect.

If this is not possible to fix, I'd be nice to know what dimensions the picture should be.

Visualization

image

How to add a page

Hello, I want to add a page to toha. I tried to do it by creating a markdown file which I placed in the data folder but I kept getting this error.

unmarshal of format "" is not supported

Is there a specific folder where I can put a markdown file to create a new page? Does toha support a different syntax?

Site meta description not showing

Screenshot from 2020-10-19 20-08-51
As you can see, the content of meta-description is not showing, even though the description is given. In the index.html file, it's using {{ .Site.Params.description }}.

So, if we move the description param from site.yaml (currently placed here) to the config.yaml and it works.

About Section Author name missing

In the about section card, there is a H3 element that should have the authors name but its empty
https://github.com/hossainemruz/toha/blob/master/layouts/partials/sections/about.html#L10
image

vs I'm assuming this is an older deployed version (perhaps prior to the localization efforts?)
image

I'm assuming you would want it to pull the name from this config https://github.com/hossainemruz/toha-example-site/blob/master/data/en/author.yaml#L2 . I tried updating the html to use https://github.com/hossainemruz/toha/blob/master/layouts/partials/helpers/get-author-name.html but it didn't seem to work so i must have been doing something wrong.

Skill cards style is wrong in Firefox

Description

When browsing the website on Firefox (Mac), Cards of Skill profile is not in shape. (See attached screenshots)

Steps to reproduce

1- Navigate to the site with Firefox (https://toha.netlify.app/)
2- select skills menu.
3- Relead page (multiple times, some time skill cards are in shape sometime not)

Expected Result

Skill cards have same height
Skill card has no large space below headline.

Actual Result

Skill cards have different height
Skill card has large space below headline.

Versions

hugo: v0.74.3/extended darwin/amd64
Theme: GIT HASH 5f48a5b
OS: Mac OS X 10.15.5
Firefox: 79.0 (64-Bit)
Toha

Incorrect Hyperlink

On the documentation, under the Usage section there's a hyperlink in "Follow the posts giving step by step instructions for configuring your data folder from here." that it's broken and i think it should point towards: https://toha.netlify.app/posts/configuration/home-section/

Newsletter functionality

Hello,

I wanted to understand the functionality of the newsletter subscription in the footer:

image

How do you configure this, how is this expected to be used? I'm sorry if I missed the documentation on this. If you could link me that would be great!

Customization of the logo

I would like to ask for the possibility to customize the logo in the top menu bar (also providing the possibility to consider two versions of the logo: the transparent version and the version visualized when the page is scrolled)

Great theme (I am waiting for the new section you are working on)

404 Icon isn't configurable

The main site's logo is configurable via the site params object, however, the 404 partial doesn't use the config properly and falls back to the default
image
image

Navbar collapse Misalignment

Navbar collapse working all fine on all web emulated devices and on my other personal mobile as well.

But this is the scene on my Samsung J2 2016 model and Safari web browser.

WhatsApp Image 2020-08-24 at 11 04 05 AM

untitled (1)

customizeable experience.yaml and markdown inside yaml

I tried to add an extra key in experience.yaml file but it is not working. Could you tell me how can I add it?. I don't want to follow your points in this file. Is there any way of using markdown syntax inside the yaml key values?

Comma with a preceding space

It's a very little issue but it should be fixed. In case both the start date and end date are specified, there is a space between the end date and the comma. Here is a screenshot.

image

It's a one-liner fix in experience-info.html.

Multilanguage Content how to?

I manage to have this theme running with multilanguage. However making a posts a different story altogether, nothing works well at least the recent post appear on the English version. But posts link just doesn't works. I have tried multi variations without such luck. Maybe some help?

You can see my code at https://github.com/tirtadji-com/tirtadji-com.github.io

Need to get more information on the structures.

Also adding id.toml to the list

Background image in low quality

Description

When browsing the website on Ipad or IPhone, the background image renders in low quality. (See attached screenshots)

Steps to reproduce

1- Navigate to the site on iphone, ipad and desktop

Expected Result

Background image must be adapted to the device's screen size

Actual Result

Rendering a low quality image

Versions

hugo version
Hugo Static Site Generator v0.74.3/extended darwin/amd64 BuildDate: unknown

Theme: GIT HASH 61a9d7a

Screen Shot 2020-08-19 at 00 51 04

IMG_0209
IMG_8423

Contributing

To start, thank you for the wonderful open source theme. I just ported my blog over to hugo and chose your theme because it was beautiful and easy to work with.

There are some defects I'd like to fix (I opened 1 pr so far here #104 ) and some enhancements around google lighthouse scores I'd like to make if you are open to them (I like for my sites too have as good of scores as possible in performance and accessibility).

I noticed the repo https://github.com/hossainemruz/toha-example-site which it seems you are using for testing updates. You have a basic guide https://github.com/hossainemruz/toha#contributing but I thought it would be useful to document your normal local development lifecycle here as it took me some time to figure out how to work with the git submodule.

On a side note, I think it would be cool if you could add the hacktoberfest topic to the repo for this month
https://hacktoberfest.digitalocean.com/hacktoberfest-update

Again, thank you for all you've done so far. Let me know if you have any guidance around contributing going forward.

Header posts are 404

Hello, I created a new article locally using the following command:
hugo new about.md

Then execute the following command
hugo server -w

On my page, the posts module is 404, and the recent posts did not show the article I just made.

May I ask where did the wrong operation happen?

My website path: https://gongguowei.com/

Attach pictures:
image

image

How to slow down the typing carousel?

Hi, love the theme (I just started with it, but will restart with your latest dynamic/configurable home page PR).

I'm having some trouble understanding the carousel js here. I'm not a js expert, but this code looks so simple - is there also some Go magic happening that helps this functionality? And my main question is: how do I slow down the typing? Say I want each letter to be typed slower, and also it to pause after each phrase is complete?

Thanks!

Add distraction free mode

Automatically hide sidebar, toc, navbar in the reading page. Make them visible again on scroll up. Or, Maybe there could be a button that toggle into distraction free mode.

Blog post handling issue

I tried to add another folder named Website in my blog section but somehow I am not getting the mistake.
Problem is the file named Website Domain is not showing inside the Website directory, rather It is displaying outside, and
main
when I click the Website directory nothing happens. How can I include the Website Domain file inside the Website directory like the GitHub folder.

Here is the condition of my relative files--

menu1_index
and

menu2_index
and

menu2_md

assets refs generated without proper baseURL

When deploying to GitHub as a project site and thus setting baseURL to e.g.

baseURL: "https://abulka.github.io/hugo_quickstart/"

hugo generates some refs ok but not css and js references. For example index.html contains:

<link rel="stylesheet" href="/assets/css/bootstrap.min.css" />

which results in the request to https://abulka.github.io/assets/css/bootstrap.min.css which is missing the hugo_quickstart/ portion of the url.

Not sure if its a theme issue or Hugo issue, but e.g. gohugoio/hugo#5226 seems to suggest theme authors might need to update their themes - something to do with .RelPermalink - or perhaps users need to do some workaround? Its a bit over my head.

The ananke theme generates urls correctly e.g.

<link href="/hugo_quickstart/dist/css/app.4fc0b62e4b82c997bb0041217cd6b979.css" rel="stylesheet">

Thoughts?

Inconsistent Word-Spacing

The word-spacing across the website seems to be inconsistent. Look at this skill for example. Some of the words are way more spaced out than others, yet they both only have one space between them.

Screen Shot 2020-07-28 at 12 51 46 PM

Screen Shot 2020-07-28 at 12 54 14 PM

Translation question

First of all thank you for this great theme! I'm using it for my site currently and want to know
if there is a way to translate the "at" in the About me area?
For example "Job title at CompanyXYZ" and under Work experience the text "Responsibilities" and "Present" for the current position.

Thanks in advance.

Missing Google Analytics when set in config.yaml

In the config.yaml you have a way to enable a Google Analytics Tracking ID. I set this but it wasn't showing up. I hardcoded it into the header partial of the theme for now.

config.yaml

  # Enable Google Analytics
  googleAnalytics: UA-XXXXXXXX

Add Indonesian language

I hope to make some small contributions to this wonderful themes. I already do a pull request and hoping to get approve.

#118

Error after upgrading theme: Failed to render "home"

I started building the site in August and after months, today I thought to update but encountered error after I synced toha theme to the latest commit.

Error: Error building site: failed to render pages: render of "home" failed: 

~/Desktop/Github/sarru1291.github.io/themes/toha/layouts/index.html:45:18": execute of template failed: template: index.html:45:18: executing "index.html" at <partial (printf "sections/%s.html" (replace (lower .section.id) " " "-")) .>: error calling partial: partial "sections/.html" not found

Gallery

Is there a way to add a picture gallery to this theme?

Accessibility and SEO

I would like to increase the google lighthouse scores of Accessibility and SEO
Example scores from my home page:
image
image

I took an initial stab at updating the home page and was able to get this
image

The remaining issue is a contrast issue between the light blue text in many places so I didn't want to change your design.
I have a work in progress branch here https://github.com/hossainemruz/toha/compare/master...alex-bezek:accessability-seo?expand=1
You can see the visual diffs in my percy build https://percy.io/alex-bezek/blog/builds/7376731?utm_campaign=alex-bezek&utm_content=blog&utm_source=github_status_public .

If this change looks good, I'll go ahead and clean it up and finish doing the posts list and single views and open a PR

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.