hulilabs / ju-shared Goto Github PK

If you look at the current error logger function it adds the error context depending on whether an Error object is provided as the first argument or not.

If the Error object isn't the first argument, a more generic stack trace will be generated and, more importantly, the context sent to the server will skip the original error message, as JSON.stringify(Error) won't work; and the common case is to log errors like Logger.error('Something custom failed', errorThrown, moreDetails...)

We should get the proper error stack regardless of the position of the error argument

Add a workaround to prevent this jQuery behavior: https://bugs.jquery.com/ticket/8417

Since merging a pull request to expose the $.ajax handler (#11) we're allowing the developers to add code that's tightly coupled with jQuery's API.

We should wrap this object with BaseProxy's methods in order to avoid such dependency.

Add libraries and helpers to give JWT support

ticket related with hulilabs/ju-mvc#2

• Provide more context for error handler
• Remove warning logs and let the app log the warnings, etc

Today I found a situation where my wifi chipset and the browser where "unreachable", ending in a situation where the window.navigator.onLine always return false. This means a user may think there is no connection BUT it does.

ENVIRONMENT
Macbook Pro 2015
Chrome Version 64.0.3282.140

The callback beforeMakingAjaxRequest in the code below simply does what the code in the else executes. I'd like to remove the callback in order for the hook to be able to do more useful processing without having the side effect of executing the ajax callback.

if ('function' === typeof this.opts.beforeMakingAjaxRequest) {
    var performAjaxRequestCallback = $.proxy($.ajax, $);
    return this.opts.beforeMakingAjaxRequest(performAjaxRequestCallback, params);
} else {
    // if no hook is provided, performs the request
    return $.ajax(params);
}

We need to add more information to the logger so we get useful data.
Adding the stack trace when there is an error would be a great start.

We are adding a new utility function to compare two objects deeply. If they have the same key values regardless of the order, the two objects will be the same.