husafan / diffable Goto Github PK

To prevent conflict with attribute names of existing projects, the attribute 
names should use "diffable." as prefix. 

What steps will reproduce the problem?
1.open google
2.search 
http://www.google.com/search?q=Albert+Szent-Gyorgyi&ct=Albert_Szent_Gyorgyi-2011
-hp&oi=ddle
3. click i am feeling lucky

4. 
What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

Branch Google's mod_pagespeed and maintain a version of the module that 
implements Diffable.

The idea here is to use a specific object to hold all the data associated to 
Diffable.
This object will be stored in the Servlet context.
The use of this object will remove the need of using static variables in 
DiffableTag.

Add testing of the bootstrap code using JSUnit tests.

If there are multiple Diffable resources on a page, then they should be able to 
chain their patch requests.  Then the server would send a single patch 
response, which would be split into individual patch responses, and applied to 
the corresponding resources.

Hi,

To ease the integration of Diffable with other projects, it will be good to 
introduce a DiffableRequestHandler which will handle the request.
This will allow to use the DiffableRequestHandler without dealing with the 
DiffableServlet.
This will enforce the separation of concern between the servlet and the request 
handling.
I suggest that the DiffableRequestHandler should have one method :

public void processRequest(ResourceRequest resourceRequest);

Cheers,
Icefox

Increase test coverage with a target of 80% on all major classes.

Every getResource call is synchronized, this has some performance penalty, I 
think that we should use the synchronisation only when we change or regenerate 
the different versions.

What steps will reproduce the problem?
1. The close of the input and output streams is not properly handle in some 
cases.

What is the expected output? What do you see instead?
The expected behaviour is a properly closing of the streams.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. Remove DiffableConfigProperties context param from the web.xml
2. Starts the webserver.
3. A nullPointerException is thrown in the DiffableListener.

What is the expected output? What do you see instead?
The expected behaviour is a proper start of the webserver and the use of the 
default values for the config.

What version of the product are you using? On what operating system?
version 0.1
Operating System : Windows 
Server : Tomcat 5.5

Please provide any additional information below.

Add a resource manager that uses a database instead of the filesystem to store 
managed resource artifacts.

Define the servletPrefix property in the config property or directly as a 
parameter of your DiffableServlet in the web.xml file.

Otherwise the user will have to repeat the servletPrefix property for 
each tag, while it can be configured once. My choice would be to put it 
directly in Servlet parameter in the web.xml file as it's nearer to the mapping 
definition of the servlet, which is done in the web.xml file. 

What steps will reproduce the problem?
1. Change the locale of your application server to France for instance
2. Launch you webserver
3. Display a page containing the diff tag
4. modify the resource used in the diff tag
5. Display the page again.
6. An illegalArgumentException is thrown on dateHeader.

What is the expected output? What do you see instead?
Retrieve of the delta from the server. 

What version of the product are you using? On what operating system?
OS:Windows
Server:Tomcat 5.5

Please provide any additional information below.

To fix this issue, we need to set the locale used by the simpleDateFormat in 
the DiffableServlet

Upload Diffable to central repositories:

http://repo1.maven.org/maven2 
http://download.java.net/maven/2 
https://maven2-repository.dev.java.net/ 
http://google-maven-repository.googlecode.com/svn/repository/ 

Modify the Javascript bootstrap code to use local storage if available. Also, 
if local storage is being used, the patched version of the code should be saved 
each time so that the user only has to patch once to a given version.

Generalize the Javascript code so that it can be more easily modified/used from 
the host page.  Also, make it so that the Javascript only has to be imported 
once, and all resources use the same bootstrap code.

When diffs become too large or a resource's contents are changed entirely, 
there needs to be a sane system for rebasing the resource and starting over in 
the generation of the deltas.  Currently, the only way to start over with a 
resource is to rename it or delete the corresponding resource store folder.  

Although this second method is not too bad, it's not easy to identify which 
resource store folder corresponds to which resource.  If nothing else, an 
artifact holding these mappings should be generated so that the correct folder 
can be quickly identified for deletion.

Should there be some sort of administrative servlet for this and other resource 
management tasks?

What steps will reproduce the problem?
1. Start Web Application using Diffable (Tested in Tomcat)
2. Shut down application server

What is the expected output? What do you see instead?

 The application server should terminate without any errors. Instead application server displays:
  Jul 14, 2010 5:31:39 PM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads
 SEVERE: A web application appears to have started a thread named [Poller SunPKCS11-Darwin] but  has failed to stop it. This is very likely to create a memory leak.

What steps will reproduce the problem?
1. Set ResourceStorePath to a Windows directory (C:/diffable)
2. Starts the application server
3. As the directory don't start with a "/", Diffable consider the path as a 
relative path.

What is the expected output? What do you see instead?
The expected output would be the use of the directory defined in the 
configuration file.

What version of the product are you using? On what operating system?
Diffable 0.1
OS : Windows XP

Please provide any additional information below.

I would suggest to use a file URI scheme to distinguish an absolute path from a 
relative path.
An absolute path would be defined as :
ResourceStorePath=file://C:/diffable
or 
ResourceStorePath=file:///usr/somepath/

And for relative path it will be :
ResourceStorePath=diffable/

What steps will reproduce the problem?
1. Open a page that uses a Diffable resource.
2. Modify the resource and open the page again so that Diffable attempts to 
load a diff.
3. Diff URL has extra / between path and resource.

What is the expected output? What do you see instead?

example expected: DiffableTest/diffable/aa_bb_cc.diff
example actual: DiffableTest/diffable//aa_bb_cc.diff

Please use labels and text to provide additional information.

Generate correct URL.  Also, modify handler to deal with trivially incorrect 
URLs such as the one above.

Add minimization for the bootstrap code.  Also, add the option of minimizing 
managed resources.