Hi,

Thanks a lot for this beautiful script.
I am using Centos8 server on a Google instance.
jq --version: jq-1.5
I also tried jq-1.6: Same result

I triple-checked my cloudfare_config and all seems fine.
I am using the correct zone ID as well.

The script works perfectly for subdomains but does not work for main domains.

For main domain I am getting the following error:

jq: error (at :1): boolean (true) and boolean (false) cannot be added
record IP needs to be updated for mysite.commysite.commysite.commysite.commysite.com
Fail to update record IP of mysite.commysite.commysite.commysite.commysite.com\nPlease Check result!!
record IP needs to be updated for
Fail to update record IP of \nPlease Check result!!
record IP needs to be updated for
Fail to update record IP of \nPlease Check result!!
record IP needs to be updated for
Fail to update record IP of \nPlease Check result!!
record IP needs to be updated for
Fail to update record IP of \nPlease Check result!!

Am I doing something wrong?
Thanks a lot

Describe the bug
Having issues using bash script with jq. It grabs the IP address properly. API token is tested and working properly.

To Reproduce
Steps to reproduce the behavior:

1. Installed jq by doing apt install jq
2. Edit configuration file
3. Made bash script executable & ran it

Desktop (please complete the following information):

• OS: Ubuntu 20.04 LXC VPS

Additional context

Dev:~/pkgs/Cloudflare-Public-Dynamic-IP-Update$ ./cloudflare_dynamic_ip_update.bash

current public IP address is HIDDENIP#
jq: error (at <stdin>:1): Cannot iterate over null (null)
jq: error (at <stdin>:1): Cannot iterate over null (null)
jq: error (at <stdin>:1): Cannot iterate over null (null)
jq: error (at <stdin>:1): Cannot iterate over null (null)
jq: error (at <stdin>:1): Cannot iterate over null (null)

Right now, the code is not well organized and it is hard to debug.
To improve readability of code and help finding the errors, The codes need to contains more descriptive and useful error message.

Check flaws of this script code

• Well Documented
• Easy to understand
• Possible security issues

OS Name and Version

Raspberry Pi OS Lite (arm32)

Release date: May 7th 2021
Kernel version: 5.10

$ uname -srm
Linux 5.10.52-v7+ armv7l

$ cat /etc/os-release 
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian

Test Result

1. Current IP is same as record's IP, must see the proper message indicating the identity

Yes. It shows my cloudflare domain and my current public IP address. Clouflare already has the right IP address.

# IP Address and Domain redacted
$ bash ./Cloudflare-Public-Dynamic-IP-Update/cloudflare_dynamic_ip_update.bash 
current public IP address is xxx.xxx.xxx.190
sub.domain.tld: no needs to update

2. Current IP is not same as record's IP, record's IP must be updated and see the proper message indicating the record has been updated

Yes. Here's how I did it:

First I changed my WAN IP address.

1. Check my current IP with curl ip.me
2. Turn off my internet modem
3. Log into my DD-WRT router's web interface.
4. Release my IP address on my WAN.
5. Spoof my router's MAC address
6. Turn on the modem
7. Wait for a new WAN IP address.
8. Double-check my IP address Changed with curl ip.me
xxx.xxx.xxx.230

Then I ran the script again.

# IP Address and Domain redacted
$ bash ./Cloudflare-Public-Dynamic-IP-Update/cloudflare_dynamic_ip_update.bash
current public IP address is xxx.xxx.xxx.230
sub.domain.tld: successfully updated to xxx.xxx.xxx.230

3. Has no connection, and see the error message

Yes.

I unplugged my modem and then ran the script.

$ bash ./Cloudflare-Public-Dynamic-IP-Update/cloudflare_dynamic_ip_update.bash
Check your internet connection, or google DNS server maybe interruptted

OS Name and Version
Indicate your OS Version e.g. Raspberry Pi 3 B+ Running Raspbian

Test Result
1. Current IP is same as record's IP, must see the proper message indicating the identity
Your Answer (No) + Some Explanation
2. Current IP is not same as record's IP, record's IP must be updated and see the proper message indicating the record has been updated
Your Answer (No) + Some Explanation
3. Has no connection, and see the error message
Your Answer (No) + Some Explanation

Additional context
Followed your guide, seems fine, changed all that need, but when i ran the script got error
Current Error when Running The Script :
jq: error (at :1): Cannot iterate over null (null)
jq: error (at :1): Cannot iterate over null (null)
jq: error (at :1): Cannot iterate over null (null)
jq: error (at :1): Cannot iterate over null (null)
jq: error (at :1): Cannot iterate over null (null)

OS Name and Version
Raspbian GNU/Linux 10 (buster)

Test Result
1. Current IP is same as record's IP, must see the proper message indicating the identity
Yes
2. Current IP is not same as record's IP, record's IP must be updated and see the proper message indicating the record has been updated
Yes
3. Has no connection, and see the error message
Yes

Additional context
Required package for jq sudo apt install jq
Required package for dig sudo apt install dnsutils

Title of this Bug
Add instructions to add zones after initial setup.

Describe the bug
Can't figure out how to add dns zones after initial install.
Please update docs with instructions.

Thank you

Modifying configuration file might be bothersome.
Add interactive configuration scripts to generate configuration file.

The new configuration file will be written as json file.
Support both appending mode and overwrite mode.

I was going to run this via cron and it's a bit chatty now.

I manually modified to remove the echo's unless there is an update of an IP as if the IP is the same, I wanted it to be 'quiet' so I can run from cron without any output coming out.

If there is an update, I do want output as everything I have in cron emails out if there is output.

Hi there is no config.json generate after successful running configure.bash.