Comments (5)
Just a note on some agreement about precedence from a call this afternoon.
The plan in the LMS app is that we will use this to switch feature flags on in some LMS instances while they are off for the h user, but we won't support disabling feature flags via this feature once they are turned on for the h user, eg. by turning the feature on for everyone in h.
The rationale is that once we flip the switch to "on for everyone in H", it means that it really is on for everyone, and there isn't a possibility that it has been disabled somewhere, so we don't have to continue to consider that possibility when testing etc.
from client.
I just want to make a comment on the above. This approach makes sense considering we have decided to enable this feature for LMS users first, and for the "public" users later, but in most of the cases we would want to do it the other way around (I assume), enabling new features for public users first.
Just to have this in mind in case we want to re-use this for future features.
Of course, we can take a completely different approach and start enabling them always for LMS users first, as if they were premium early access features for paying customers.
from client.
This approach makes sense considering we have decided to enable this feature for LMS users first, and for the "public" users later, but in most of the cases we would want to do it the other way around (I assume), enabling new features for public users first.
We can still enable for public users first with this approach. There is a checkbox for feature flags in h which allows a feature to be turned on for first party (ie. public) users only. This is separate from the "everyone" checkbox which means first + third-party users.
In fact, for import/export it is still the plan to turn it on for public users first AFAIK.
from client.
We can still enable for public users first with this approach. There is a checkbox for feature flags in h which allows a feature to be turned on for first party (ie. public) users only. This is separate from the "everyone" checkbox which means first + third-party users.
Right, I always forget about the "first party" option. Then I think we are covered 👍🏼
from client.
This is now deployed.
from client.
Related Issues (20)
- Can't annotate https://community.canvaslms.com/ (issue with tsParticles) HOT 2
- Validate max length for tags
- Error with iframe `allow` attribute when annotating pages on archive.org HOT 6
- Migrate to eslint flat config HOT 1
- Create a new toast-like notification that is displayed when there are pending updates HOT 2
- Add accessible `tabpanel` role to the panels handled by selection tabs in the sidebar
- Hide "annotate" and "highlight" icons from "Getting started" tab to screen readers
- Consider automatically closing the help panel if auto-opened and user creates annotations HOT 2
- Optionally preserve (carry over) tags for the ensuing annotation
- can't log in at Edge add-on HOT 7
- Multiple annotations by the same person have the same accessible title HOT 3
- Annotation cards can be interacted with the mouse but not with the keyboard
- Reconsider the usage of "dialogs" for non-modal sidebar panels
- When loading pending updates, consider scrolling to the "closest" one, not the latest one HOT 2
- Incorrect Conversion of Overlapping Highlights or Notes Upon Page Navigation HOT 5
- Adder not fully visible due to z-index miscalculation
- Chrome extension doesn't open H overlay on Reddit.com HOT 1
- Hypothesis expects Host in parent frame, not in any ancestor or top frame HOT 2
- Whenever an iframe changes location Hypothesis needs to be injected again HOT 2
- Mechanism for disabling creating annotations and displaying highlights on the host frame for enable-annotations iframe use cases HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.