Giter VIP home page Giter VIP logo

Comments (5)

robertknight avatar robertknight commented on August 16, 2024

Just a note on some agreement about precedence from a call this afternoon.

The plan in the LMS app is that we will use this to switch feature flags on in some LMS instances while they are off for the h user, but we won't support disabling feature flags via this feature once they are turned on for the h user, eg. by turning the feature on for everyone in h.

The rationale is that once we flip the switch to "on for everyone in H", it means that it really is on for everyone, and there isn't a possibility that it has been disabled somewhere, so we don't have to continue to consider that possibility when testing etc.

from client.

acelaya avatar acelaya commented on August 16, 2024

I just want to make a comment on the above. This approach makes sense considering we have decided to enable this feature for LMS users first, and for the "public" users later, but in most of the cases we would want to do it the other way around (I assume), enabling new features for public users first.

Just to have this in mind in case we want to re-use this for future features.

Of course, we can take a completely different approach and start enabling them always for LMS users first, as if they were premium early access features for paying customers.

from client.

robertknight avatar robertknight commented on August 16, 2024

This approach makes sense considering we have decided to enable this feature for LMS users first, and for the "public" users later, but in most of the cases we would want to do it the other way around (I assume), enabling new features for public users first.

We can still enable for public users first with this approach. There is a checkbox for feature flags in h which allows a feature to be turned on for first party (ie. public) users only. This is separate from the "everyone" checkbox which means first + third-party users.

In fact, for import/export it is still the plan to turn it on for public users first AFAIK.

from client.

acelaya avatar acelaya commented on August 16, 2024

We can still enable for public users first with this approach. There is a checkbox for feature flags in h which allows a feature to be turned on for first party (ie. public) users only. This is separate from the "everyone" checkbox which means first + third-party users.

Right, I always forget about the "first party" option. Then I think we are covered 👍🏼

from client.

robertknight avatar robertknight commented on August 16, 2024

This is now deployed.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.