Comments (2)
robertknight
commented on July 17, 2024
What is happening here is that when the page is saved, the annotator JS bundle and the <hypothesis-sidebar> DOM element, with its shadow DOM content, are saved into the page. When the saved page is loaded, the iframe within the serialized <hypothesis-sidebar> element is loaded, but then the annotator JS bundle launches and creates a second <hypothesis-sidebar> with its own iframe. Depending on which of these iframes loads first, one will fail to connect to the host page.
https://bugs.chromium.org/p/chromium/issues/detail?id=106158 describes a more general version of this problem when a serialized web page includes both DOM elements and the JS scripts that created them.
from client.
robertknight
commented on July 17, 2024
I expect there will be similar issues when saving pages in Safari and Firefox, but I have yet to test this.
from client.
Related Issues (20)
- Use SelectNext for the import/export user dropdown
- Dark Mode
- Add keyboard shortcut dialog
- Filter annotations in VitalSource assignments based on page range / chapter HOT 1
- SPIKE: Verify functionality of new NVDA screen reader + firefox (Requires Windows) HOT 2
- link url is outdate cannot redirect to the correct page HOT 1
- Indicate when user is outside page range for assignment
- Hide annotations that are outside of assignment page range HOT 3
- Investigate ExportAnnotations a11y test failing when using the new SelectNext with role="combobox" HOT 2
- Revisit the use of arrows in menus/popovers HOT 2
- Sidebar's bottom scrollbar briefly appears when an annotation is created
- Active group name gets "compressed" when search box is opened
- services.icon is documented, but not working HOT 1
- Show page numbers on annotation cards HOT 4
- Design how the various search and filtering modes interact HOT 5
- Make real time updates easier to see HOT 4
- Personal annotations
- Capture and display info about headings associated with annotated text in HTML documents
- Search panel closes with transition when clicking "X" but not when pressing Escape HOT 4
- Support for highlighing Media files and taking screenshots HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.