Giter VIP home page Giter VIP logo

Comments (3)

robertknight avatar robertknight commented on August 16, 2024

A complication with this is that annotations created on EPUB-based books do not currently record page number selectors, so if the assignment range is expressed as a page range, rather than a CFI range, we cannot filter annotations against it them.

Some things we can do:

  1. Start record page number selectors for all annotations, whether the book is PDF or EPUB-based. An issue with this is that we won't have these selectors for existing annotations.
  2. Map the CFI for each annotation to a corresponding page number. We might be able to do this with the data that VS exposes to our code. A downside is that we won't have access to this information outside the context of the assignment (eg. in a future iteration of the notebook).

from client.

robertknight avatar robertknight commented on August 16, 2024

This will be basically working once hypothesis/lms#5930 lands, with UI improvements to follow (see #6006).

from client.

robertknight avatar robertknight commented on August 16, 2024

I'm marking this as done. Making toggling the visibility of annotations outside the page range more usable is necessary though and is covered by #6006.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.