Giter VIP home page Giter VIP logo

Comments (6)

xriss avatar xriss commented on August 15, 2024 1

Ahh, looks like I might be out of date and it is now intended for region+country to add up to 100%

The simplest "hack" would be to add regions to the country code list, and maybe stop referring to it as countries.

from d-portal.

xriss avatar xriss commented on August 15, 2024

A slight spanner in the works is when transactions/budgets are split over countries it is exclusive. This is also true of regions, however is is not true of a mix of countries and regions. This was the main problem we originally raised and why it did not happen.

So if you ask for region A and country B it is possible for a single activity to allocate all of its money to region A and country B creating an obvious double accounting problem.

from d-portal.

stevieflow avatar stevieflow commented on August 15, 2024

Thanks @xriss

The IATI schema changed in 2.0x ( I think - can double check --> but I think that's metioned in #239_ so that recipient-country+region in any activity should add to 100%

Of course, that's not always followed - but can be filed with all other validation issues

@IsabelBirds - I think there are specific rules where recipient-country+region do not sum to 100%, which are then surfaced in the validator?

from d-portal.

xriss avatar xriss commented on August 15, 2024

I think we are good at assuming country+region add up to 100% but this is going to involve changing how non explicit transactions are split and I'm not sure its easy to do in a way that can be previewed since it is a major change to how the database is built. I will have to redo the transaction splitting code at import time and probably clean up the logic as it is currently rather overly complex.

So this will be a change ( to the calculated numbers ) when we push it live with no easy way to preview. Obviously I will keep it to a minimum and try not to break old country code but it will involve a slightly scary backend change.

@notshi suggestion is to rename countries to recipients which can then also include regions. Shall we go ahead and make that UI change behind the test flag?

from d-portal.

stevieflow avatar stevieflow commented on August 15, 2024

Thanks @xriss @notshi - understood

suggestion is to rename countries to recipients which can then also include regions.

There's a risk then that people might think this is actual recipients, as in organisations / receiver-org --> if needs, then rename to "Country/Region"?

Thanks

from d-portal.

IsabelBirds avatar IsabelBirds commented on August 15, 2024

At the activity level- "Percentage values for recipient countries or regions, must add up to 100%."
https://github.com/IATI/validator-rule-tracker/blob/e49edd0b4d78446581918595c90ecb3348925ca4/rulesets.csv

At the transaction level - both region and country say "This element must occur no more than once (within each parent element)." But this is not in the validator.
https://iatistandard.org/en/iati-standard/203/activity-standard/iati-activities/iati-activity/transaction/recipient-region/

from d-portal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.