ibm / max-image-colorizer Goto Github PK

API endpoint /model/predict returns HTTP status code 500 if an invalid image input is provided. It should return status code 400 if an error is caused by input that cannot be processed because it doesn't meet the [stated] requirements.

README.md contains this line:
curl -F "image=@assets/bw-city.jpg" -XPOST http://localhost:5000/model/predict > result.png && open result.png

however open is a command specific to OSX, we should remove this or specify it only works on Mac

the README contains this link to the model files:

• http://max-assets.s3-api.us-geo.objectstorage.softlayer.net/tf/pix2pix/pix2pix-bw-to-color.tar.gz

this works. however, it is different than the link in the Dockerfile:

• http://max-assets.s3-api.us-geo.objectstorage.softlayer.net/image-colorizer/1.0/assets.tar.gz

i would expect both of these to point to the same set of model files.
in addition, both of the links should be pointing to the new US cross region:

s3.us.cloud-object-storage.appdomain.cloud

because the old one has been deprecated:

s3-api.us-geo.objectstorage.softlayer.net

$ docker --version
Docker version 17.09.0-ce, build afdb6d4

$ docker build -t MAX-Image-Colorizer .
invalid argument "MAX-Image-Colorizer" for t: invalid reference format: repository name must be lowercase
See 'docker build --help'.

I had to replace MAX-Image-Colorizer with max-image-colorizer to start the build successfully.

Example in PR:
IBM/MAX-Object-Detector#20

Example PR:
IBM/MAX-Review-Text-Generator#7