Support mobx-state-tree about mobx-react-router HOT 4 CLOSED

I guess we still might want the unsubscribe method exposed, as that gives the user a way of disconnecting the router state from the history (unsubscribing the store from the browser history) if they **really ** needed to.

So for the name: I guess mobx-state-tree-react-router rolls off the tongue nicely...
Maybe just mst-react-router would work.

I'd be happy to quickly whip up the library in the next couple of days to get a basic first concept going.
I'll link it back on here when it's up so you can take a look and suggest any changes 👍

from mobx-react-router.

I'm open to it, and it doesn't seem like too much extra code.

However, I'm just considering how to go about it. As there will need to be a peer dependency on mobx-state-tree in this library (because of the types.model stuff), even people not using mobx-state-tree will get "missing peer dependencies" warnings constantly.

It seems that the best way to go about this (unfortunately) might be to create another router binding library specifically for mobx-state-tree.
mobx-state-tree has such a different API to pure mobx observables, that trying to merge router bindings for both probably doesn't make sense.

Open for discussion though.

Edit:
Actually users would be required to install MST, because of the references to types.model, unless we create a completely separate target (bundle) for MST users

from mobx-react-router.

True, I'm also for the idea of a different library, quite some things would be different.

For example you wouldn't need the subscribe and unsubscribe methods with mobx-state-tree, thanks to its helper function onSnapshot (or others) to which you can pass the router branch.

For example this is my simple implementation of the syncHistoryWithStore function

export const syncHistoryWithStore = (history, store) => {
  // Set initial history and location
  store._setHistory(history)
  store._setLocation(history.location)

  // Handle update from history object
  history.listen(location => store._setLocation(location))

  return history
}

from mobx-react-router.

Took a bit longer than I hoped, but v1.0.0 is now live: https://github.com/alisd23/mst-react-router.

Thanks @dbertella and @marcofugaro for the help with the initial investigation/code.

🎉 🎉 🎉 🌮

from mobx-react-router.