Comments (11)
ok, that seems reasonable, I can change the merge-to-staging script to only merge openj9 if new master content... and also don't try and build if nothing merged so as to prevent alarming unecessary build failures... i'll work on that
from openj9-openjdk-jdk.
i've updated the merge scripts, it will only update openj9-staging if new master changes are available to be merged...
from openj9-openjdk-jdk.
@andrew-m-leonard @AdamBrousseau
from openj9-openjdk-jdk.
Examples are
https://ci.eclipse.org/openj9/view/Pipelines/job/Pipeline-OpenJDK11-Acceptance/17/
https://ci.eclipse.org/openj9/view/Pipelines/job/Pipeline-OpenJDK11-Acceptance/18/
from openj9-openjdk-jdk.
These look fine, they are both triggered from nightly merge to staging jobs, respectively:
https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJDK%20Team%20-%20Merge%20Jobs/job/Nightly-Merge-to-Staging-and-Build-Test-pipeline-JDK11/40/
https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJDK%20Team%20-%20Merge%20Jobs/job/Nightly-Merge-to-Staging-and-Build-Test-pipeline-JDK11/41/
from openj9-openjdk-jdk.
Remember also that openj9-staging may get new changes from the openj9 branch during a nightly merge-to-staging branch, which is necessary as openj9-staging builds with "latest" Eclipse/openj9 so has to build with latest openj9 branch, eg.for recent GPUHandlerMethod dependent changes...
from openj9-openjdk-jdk.
They aren't testing anything new. They are wasting valuable machine time running acceptance builds on code which is already tested via the nightly build. Not sure we have enough machine power to run the testing that should be run, so wasting time running unnecessary things is not ideal.
from openj9-openjdk-jdk.
I see the need to keep the staging
branch in sync with the openj9
branch but imo we only need to push it up if there is new content from master
. Nobody will be building the staging branch so if it is out of date until the next refresh from master
I think that is fine.
from openj9-openjdk-jdk.
@AdamBrousseau @pshipton one thought crossed my mind, what if the AcceptanceJob fails for whatever reason, what will trigger the job again if no new master push occurs? can some "state" be stored that would indicate it needs to be re-tried or something resolving? or would we rely on a manual re-submit?
from openj9-openjdk-jdk.
It is up to the build monitor(s) to keep an eye on it and take appropriate action (which I have done in the past for jdknext). If the acceptance failure is posted to Slack (#jenkins) then this is easy. If the acceptance fails quietly, it likely won't be noticed, at least not for some time. As we get closer to a release, there will be more attention on making sure the latest levels are integrated. I think we have all the "state" we need, it is obvious looking at the openj9-staging branch and the acceptance builds what is going on.
from openj9-openjdk-jdk.
Thanks, closing then.
from openj9-openjdk-jdk.
Related Issues (20)
- Build_JDKnext_x86-64_windows No rule to make target 'java.desktop<cr>' HOT 1
- Windows openj9-staging failing to compile, merge problem HOT 6
- Include debug symbols in the SDK HOT 3
- Github actions from upstream OpenJDK running on PRs HOT 1
- Have builds print the SHAs being used HOT 10
- Update Openj9PropsExt.java to set necessary Properties for @requeries expressions HOT 1
- Contribute #260 to OpenJDK HOT 4
- Contribute #282 to OpenJDK
- Re-enable NativeGCM lost due to OpenJDK update 8255557: Decouple GCM from CipherCore HOT 2
- Missing TEST.groups file needed to enable AGCT unit testing HOT 8
- Tags in extension repos HOT 1
- --disable-warnings-as-errors-o* is ignored in cmake mode HOT 5
- CRIU: Performance regression
- Porting adopting RI java.lang.Thread/ThreadGroup w/ --enable-openjdk-thread-support to other Java levels HOT 2
- Enabling CMake by default for cross-compiles HOT 14
- PR build limitation: test framework takes the default extension repo branch instead of current change HOT 2
- openjdk-tag.gmk:OPENJDK_TAG doesn't match actual openjdk tag merged HOT 1
- Contribute #535 to OpenJDK HOT 2
- Extension test change is not picked up by PR builds. HOT 7
- SunPKCS11 fails silently when there is an error in the PKCS11 configuration file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openj9-openjdk-jdk.