icecreamyou / html5-canvas-game-boilerplate Goto Github PK

Chrome frame is no longer developed or supported, See The Chromium Blog.

Within the Actor.collideSolid() function there is a section of code:

...
else if ((typeof Collection !== 'undefined' && collideWith instanceof Collection) ||
    (typeof TileMap !== 'undefined' && collideWith instanceof TileMap)) {
  var items = collideWith.getAll();
...

This results in an error when collideWith is a Collection, because getAll() is not defined in Collection (only in TileMap)

A similar problem occurs in Actor.standingOn()

My solution was not to add an additional clause to these if statements, but to standardise by adding to the Collection.prototype:

getAll: function() {
  return this;
},

When creating multiple new TileMap objects, there is a problem with re-using the same array as an input argument:

var gridAsString = 'B\nP';
var gridAsArray = [['B'], ['P']];

// Using a string works correctly:
var blocks = new TileMap(gridAsString, { B: Block });
var pots   = new TileMap(gridAsString, { P: Pot });

// But using an array is broken:
var blocks = new TileMap(gridAsArray, { B: Block });
var pots   = new TileMap(gridAsArray, { P: Pot });

I believe this is because of the code overwriting the grid argument by reference. By the time the pots collection is being created, gridAsArray is already partly filled with Block objects.

To fix this, I just added one line immediately below the function start:

...
function TileMap(grid, map, options) {
  var grid = JSON.parse(JSON.stringify(grid));

  // Setup and options
...

I think this is all the cloning that is necessary. I'm not a Javascript native, so there may be something I've overlooked.

Thanks.

I have these errors in the console:
Uncaught TypeError: Cannot read property 'startCoords' of undefined combined.min.js:8
Uncaught TypeError: Cannot call method 'draw' of undefined

Running on a wamp environment, chrome.