icgc-dcc / dcc-dev Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 1.0 1.16 MB

Data portal development server

License: Other

Java 50.37% HTML 2.79% JavaScript 12.97% Shell 17.85% Python 2.38% TypeScript 12.42% CSS 1.23%

dcc-dev's People

Contributors

Stargazers

Watchers

Forkers

lequoctoan

dcc-dev's Issues

Deployed Portal "Notes" should be displayed as normal text

Notes for deployed portals should be displayed as normal text, until an "edit" button is clicked, which would then make it editable

Either turning it into an in-place text-area (pro: more fluid, least interrupting interaction, con: not a lot of space), or pop a modal with a larger editing area.

Which one we use should depend on how long the notes tend to be

De-emphasize "Create new portal" interaction for candidates with existing portals

Intent - to discourage unnecessarily creating duplicate portals, without completely disabling the ability to create multiple portals off of the same candidate (for comparison purposes)

Candidates with existing deployed portals should have their "Create" button de-ephasized

A list of portals that were created from that candidate (there should usually only be 1, at most 2) should be shown in the Candidate's card, with a button that would trigger a manual redeploy with the newest build for that candidate

The "Create new portal" interaction would be placed after the "redeploy existing portal" interactions, in a more diminutive state

Issue commands via Github comments

deploy to dev
build and deploy
ready for review
build, deploy, post to #portal with URL and ticket

Would be great to be able to show jira comments under the portal in the portal page

2016-08-16 13:57:19,437 [http-nio-9000-exec-7] ERROR o.a.c.c.C.[.[.[.[dispatcherServlet] - Servlet.service() for servlet [dispatcherServlet] in context with p
ath [] threw exception [Request processing failed; nested exception is java.lang.NullPointerException] with root cause
java.lang.NullPointerException: null
        at org.icgc.dcc.dev.server.jenkins.JenkinsService.isSuccessfulBuild(JenkinsService.java:110)
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
        at java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1812)
        at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126)
        at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:498)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:152)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:464)
        at org.icgc.dcc.dev.server.jenkins.JenkinsService.getSuccessfulBuild(JenkinsService.java:96)
        at org.icgc.dcc.dev.server.portal.candidate.PortalCandidateResolver.createCandidate(PortalCandidateResolver.java:82)
        at org.icgc.dcc.dev.server.portal.candidate.PortalCandidateResolver.lambda$resolve$0(PortalCandidateResolver.java:78)
        at java.util.Optional.map(Optional.java:215)
        at org.icgc.dcc.dev.server.portal.candidate.PortalCandidateResolver.resolve(PortalCandidateResolver.java:78)
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
        at java.util.Iterator.forEachRemaining(Iterator.java:116)
        at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
        at org.icgc.dcc.dev.server.portal.candidate.PortalCandidateResolver.resolve(PortalCandidateResolver.java:68)
        at org.icgc.dcc.dev.server.portal.PortalService.getCandidates(PortalService.java:90)
        at org.icgc.dcc.dev.server.portal.PortalController.getCandidates(PortalController.java:81)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)```

slug (web industry standard, originates from print publishing)
prettyUrl
semanticUrl

To be derived from pull request title, with additional collision protection (Since PRs can have duplicate titles)

Derive Portal Title from PR title. Update Portal Title when PR title changes

Portal instances should prominently display the portal instance id

This is the main identifier of the instance and is currently not shown.

[FE] Make "candidates" and "deployed portals" more vis[FE] Make "candidates" and "deployed portals" more visually distinctually distinct

Collapse "candidates" to only contain "title", "owner image", and the "create" button

Hide the other controls behind an "expand" interaction