ichef / gypcrete Goto Github PK

Currently all sub-packages list @ichef/gypcrete as dependency.
This causes lerna to update every single package (and thus publish them) just for updating dependency to the core package.

Let's see if we can list the core package as a peer dependency instead.

Currently node-sass breaks when building under Node 10.

• <Text> aside isn't turned white when placed inside a highlighted row
• A <ListRow> does not have hover background in normal <List>
• <HeaderRow> should also apply vertical padding

Before upgrade react

• Upgrade storybook dependencies to v3.2.11 or above. (#93)
• Upgrade enzyme to v3. (#183)
  • React dependencies was removed in enzyme v3, use new Adapters system to import React library that we used, check the migration guide here.
• Upgrade webpack and extract-text-webpack-plugin to v3 (#101)
• Upgrade Babel to v7 (#185)
• Upgrade ESlint v5 (#186)

React API changes

• Upgrade react, react-dom, react-test-renderer to v16. (#187)
• As #79, Migrate unstable_renderSubtreeIntoContainer to ReactDOM.createPortal(). (#188)
• Get rid of ReactDOM.findDOMNode() as it's being deprecated under strict mode in React 16.6. (#189)

There are 3 components left using a previous “input object”, which explicitly expects an input prop to pass all input-related props to their inner <input>. They are:

• <Checkbox>
• <SearchInput>
• <Switch>

As their main purpose is to act as real inputs with custom appearance, they should take all unknown props as input props by default.

To match new API design for React Storybook. See #95.

This issue is created to keep track of minimum requirements for release v1.0.0.

Visual Elements

• Text (#5, #40)
• Icon (#4)
• Tag (#4)
• Tooltip (#16)
• Switch Icon (#37)
• States (#4)

Row Components

• Text Label (#7, #43)
• Button (#14)
• Button (icon-only) (#15)
• Checkbox (#27)
• Switch (#37)
• Text Input (#41)
• Text Input (multi-lines) (#64)
• Search (#21)

Containers

• Header (#69)
• Row (#69)
• List Section (#69)
• Setting Section (#69)

Split gypcrete into multiple packages but still maintain in one single repository.

Switch from unstable_renderSubtreeIntoContainer() to unstable_createPortal() for compatibility with React Fiber.

Related informations:

• palantir/blueprint#1509
• facebook/react#10309

TBA

Most our components in gypcrete are stateless function components. That means they take up less resource in a React app but they can not be held via a ref. And thus they cannot be used as the anchor of an anchored component.

There are 2 feasible solutions:

1. Make every row components React.PureComponents.

   • Pros → No extra wrapper needed to be used as an anchor.
   • Cons → This will make components fat in terms of memory usage and performance.

2. Create a PureComponent wrapper to take the reference for its content

   • Pros → Only anchors need this extra PureComponent, and this anchor can hold multiple components.
   • Cons → Dirty markups. And you need to deal with Flexbox issues.