icn-team / android-sdk Goto Github PK

CMake 17.97% Shell 9.87% Java 46.93% C 3.02% Makefile 5.35% C++ 16.46% Dockerfile 0.16% Python 0.25%

android-sdk's Issues

Facelet adapter not properly synchronized with backing list in InterfacesFragment

When the hICN stack stops (eg. because of inactivity), and the user is on the Interfaces tab displaying the list of faces, the application crashes.

This is due to a clear() on the backing list without notifying about a change in dataset in InterfacesFragment.java. Some propose to notify just after the change in dataset, but the alternative (and preferred here) solution is to directly call clear() on the adapter itself, in particular for uniformity with the rest of the code (add()).

I expect the call through the adapter would solve potential race conditions between the list update and the time when the adapter is notified, as the method could take care of running everything in the UI thread. However the current code is explicitely calling those methods in the UI thread, so for safety and until confirmed, the clear() has also been moved in the UI thread. This choice is further motivated by the last change.

By default, setNotifyOnChange is true, which means the adapter takes care of calling notifyDatasetChanged after any modification. The code was thus unnecessarily calling it after adding elements, since this was redundant, but likely inserted for optimization purposes. The setNotifyOnChange has thus been set to false, and the notification is explicitely in both clear() and add(). With such delayed operations, i doubt the code could ever be safe otherwise.

Additional note: this code never clears the list of facelets unless the face manager is found in a stopped state: this is okay as soon as facelets are never removed in the face manager, which is indeed the case. A comment has been added in the file to clarify this aspect.