icyapril / cryptolib Goto Github PK

"Will return openssl_random_pseudo_bytes with desired length is $strong is set to true." needs to be changed.

Fatal error: Call to undefined function hash_pbkdf2() in CryptoLib.php on line 193.
This is real bummer, as u mentioned in your documentation and in file that it will work with "Requires OpenSSL, MCrypt > 2.4.x, PHP 5.3.0+".

hash_pbkdf2 is available in PHP code from 5.5 version only.

This is a great library but could you provide a little more information on the SHA512 algorithm you are using? I’m no security expert but is this the SHA3-512 with an output of 512 bits or the SHA-512/256 with a 256 bit output?

Change class version from v0.8 Christmas to v1.0 Conqueror in class description in CryptoLib.php

From CryptoLib.php:

<?php
namespace IcyApril;
    /**
     * Class CryptoLib (v0.8 Christmas)
     * Created by Junade Ali
     * Requires OpenSSL, MCrypt > 2.4.x, PHP 5.3.0+
     */

...

In PHP 7.1, all mcrypt_* functions will raise an E_DEPRECATED notice.

In PHP 7.1+1 (be it 7.2 or 8.0), the mcrypt extension will be moved out of core and into PECL, where people who really want to install it may still do so if they can install PHP extensions from PECL.

https://wiki.php.net/rfc/mcrypt-viking-funeral

Would you mind if I made this into an apache extension for faster execution speeds? I get between 38-55ms when executing the validateHash function which is fast because I have decent hardware on my machine. But for machines that have less power, it could be faster if written and compiled code such as C.

https://github.com/IcyApril/CryptoLib/blob/master/src/CryptoLib.php#L233

http://blog.ircmaxell.com/2014/11/its-all-about-time.html

Hi,

is it possible that this library will be made available for composer? Sucks that I have every library via composer except this awesome one here.

Is the generaterandom string secure enough to be used as an anti-csrf token?