Giter VIP home page Giter VIP logo

react-spotify-api's People

Contributors

dependabot-preview[bot] avatar idanlo avatar jb1905 avatar samjt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

react-spotify-api's Issues

Improve Api Error Handling

@idanlo Thanks for the great work on this project!

Using the library I noticed it does not set an error state when the API returns a non-200 status code. The error JSON data is returned in the data field.

Reproduction:

import { SpotifyApiContext, Artist } from 'react-spotify-api';

<SpotifyApiContext.Provider value="bad_access_token">
  <Artist id="6eUKZXaKkcviH0Ku9w2n3V">
    {(artist, loading, error) => (
      <div>
        <p>Artist: {JSON.stringify(artist)}</p>
        <p>Error: {JSON.stringify(error)}</p>
        <p>Loading: {JSON.stringify(loading)}</p>
      </div>
    )}
  </Artist>
</SpotifyApiContext.Provider>

Result:

Artist: {"error":{"status":401,"message":"Invalid access token"}}

Error: false

Loading: false

I would like to propose setting an error object when encountered with the API or at the very least set to true. Do you have any thoughts on this? Happy to help ๐Ÿ˜„

Request token expires

I first want to say how nice this library has been so far! Thank you.

I have installed version 3.0.0 and have hit an issue with my token expiring. From the docs, I gained the impression that the library would handle refreshing the token itself as long as I provide one when initilizing the provider. Is this a bug or am I misreading the docs?

Distribution build uses a regeneratorRuntime function that doesn't exist

Hi,

It looks like you're using regeneratorRuntime in the compiled useApiRequest.js, probably via compilation from Babel.
From dist/ApiRequest/useApiRequest.js

function _loadData() {
    _loadData = _asyncToGenerator(regeneratorRuntime.mark(function _callee() {
      var res, _data;

      return regeneratorRuntime.wrap(function _callee$(_context) {
...

But regeneratorRuntime itself is not defined nor imported.
I think that you need to update your .babelrc to include an extra babel plugin

I cannot seem to make any component working

When i try to implement any example component from the docs it never works. What am I doing wrong ?
Here's one of my component

import React from 'react';
import {Playlist} from "react-spotify-api"

function PlaylistComponent(props) {
    return (
        <Playlist id={props.id}>
            {({playlist}) => {
                return playlist ? <h3>{playlist.name}</h3> : null
            }}
        </Playlist>
    )
}

export default PlaylistComponent

QA: Can it be used with React Native?

This looks very promising I was wondering if it can be used with react-native and possibly expo.
I saw the html elements but they can be easily switched to the react native elements, is there anything that would stop this from working in react native and expo?
Thanks!

Remove axios and use the fetch api instead

axios takes a large size of the package (almost 50%) and I do not have any special uses that require the use of axios (only query params but this can be done with fetch).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.