Prerequisites

• [ X] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Provide support for debian buster (10)

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

OWASP recommends to change SHUTDOWN command word from 'SHUTDOWN' to other ('ReallyComplexWord' xd)

Expected behavior: SHUTDOWN command should be configurable

Actual behavior: We cannot change SHUTDOWN command because is hardcoded in the server.xml.j2 template

Versions

All

Additional Information

OWASP - Protecting the Shutdown port

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

As Tomcat 7.x and Tomcat 8.x are currently mantained versions of Tomcat, it would be nice to add scenarios testing that are supported versions that could be installed using this role. These versions should be explicitly specified as supported versions in the Readme file

Prerequisites

• [ X] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

When you run the role twice it will download and configure the agent every run.

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

Expected behavior: Only do things when its necessary.

Actual behavior: Download and configure the agent every time.

Reproduces how often: Always

Versions

Since 1.5.x

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Prerequisites

• [X ] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

During deploy the role downloads a war and copy it to webapps folder without modifying the name. This is is a problem because some projects wars name usually includes other information like profile or version that should be remove when copied to webapps

Expected behavior:
The role should be able to process a list of war urls with a destination name. Download the war and copy it to webapps with desire destination name.

Description

When installing a java jar agent directly the configuration section is not working as intended.

Environment

• The release version/s you are using:
• OS:
• Others:

Additional Information

[Any additional information, configuration or data that might be necessary to reproduce the issue.]

Hi,

the current implementation allows only to deploy from the control node to the target node. But sometimes the war file might already be available on that target machine so it should be possible to also define if the parameter remote_src should be used or not.

Like this:

- name: Tomcat | Copy local wars to webapps
  copy:
    src: "{{ item }}"
    dest: "{{ tomcat_webapps_path }}"
    mode: 0755
    owner: "{{ tomcat_user }}"
    group: "{{ tomcat_group }}"
    remote_src: "{{ tomcat_war_to_deploy_use_remote_src }}"
  with_items: "{{ tomcat_war_to_deploy_path }}"
  when: tomcat_local_wars

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Most of the tasks can work just fine in EL, except for the apt step in deploy, from what I can tell. Please add support for EL.

Steps to Reproduce

1. Run on EL
2. Find failures
3. Fix

Expected behavior:
Success

Actual behavior:
Failure

Reproduces how often:
100%

Versions

1.8.0

Additional Information

N/A

Description

Role fails when two agents are installed in two separated periods of time. More info in the section below.

Steps to Reproduce

1. Run the role and install an agent
2. Empty /tmp
3. Run the role installing a second agent, in addition to the first one

Expected behavior:
Do not fail in step 3, installing the two agents successfully

Actual behavior:
Role fails in the first run, making it mandatory to run the role twice in order to have a proper execution

Reproduces how often:
100%

Environment

N/A

Additional Information

N/A

Description

Tomcat should not show its version when showing an error, or atleast this should not be the default behaviour

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Pipfile and Pipfile.lock (autogenerated files by Pipenv) shouldn't be added to the repo

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

get_url module doesn't work properly on different version but same name war downloaded.

Steps to Reproduce

1. Download any war version
2. Download other war version but with same name
3. The get_url module doesn't override the file

Description

I need support for addons like java agents (newrelic, datadog, etc.) in this role.

Expected behavior: With the provided configuration I expect not to do more modifications when this role is executed.

Actual behavior: I need to modify the configuration after this role is executed.

Versions

All versions

Prerequisites

• [X ] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Systemd ignores limits.d configuration managing services. The cassandra.service template can be improved in order to add, at least:

memlock
nofile
as
nproc

Steps to Reproduce

1. systemct start cassandra

Expected behavior:
Get configured limits.

Actual behavior:
Limits not configured.

Reproduces how often:
Always.

Versions

All

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Description

Tomcat 10 is out now and this role fails while trying to install it.

Additional Information

https://tomcat.apache.org/download-10.cgi

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

This role should be able to be fully compatible with ansible 2.9.

Description

Add support for downloaded agents as jar instead of compressed file.
Newrelic publishes his agent as a compressed file but other solutions (like elastic apm, etc.) is published as a jar.

Why is this needed?

Complete support for all agents.

After installing and configure tomcat it would be good to have a task that copy wars to CATALINA_HOME/webapps .

Description

This role only supports solrcloud mode.

Additional Information

[Any additional information, configuration or data.]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Cannot copy extra tomcat config recursively

Steps to Reproduce

1. Create a folder inside tomcat_extra_conf_path (playbook_path/templates/tomcat/conf/Catalina/localhost/)
2. Put your configuration template in that folder

Expected behavior: That template should be copied in that path

Actual behavior: Folders declared in step one are created but the config template is not copied

Reproduces how often: always

Versions

all

Description

Some java agents supports extensions to add more functionality. This role doesn't support it yet.

Why is this needed?

The role supports java agents but extensions not yet.

Description

Memlock and AS security limits have a default value "unlimited" but systemd changed traditional syntax and use "infinity" value.

Steps to Reproduce

1. Use limits default values from role.
2. Start service.

Expected behavior:
Limits are set to unlimit.

Actual behavior:
Systemd warns limit values are not recognized.
Reproduces how often:
Always.

Environment

• The release version/s you are using:
• OS: all

Additional Information

N/A

Migrate to Molecule 2.X.X

Description

Because of several CVEs related to log4j JNDI vulnerabilities, it would be nice to add the following flag by default

-Dlog4j2.formatMsgNoLookups=true

Why is this needed?

To prevent the exploit

Additional Information

CVE-2021-44228

Prerequisites

• [x ] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Systemd notice the service is started but the applications managed aren't started.

Steps to Reproduce

1. $ sudo systemctl start tomcat.service

Actual behavior: Tomcat managed services doesn't start

Reproduces how often: Always

Versions

1.1.0

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

We should use Goss instead Testinfra to check:

• Default tomcat port is opened (8080)
• Default shutdown port is opened (8009) (and not opened if it's configured with '-1' value in other scenario). Check that configured shutdown command also works.
• Tomcat version
• Tomcat user exists
• Tomcat service is running
• Tomcat is up and running (HTTP check) with sample.war
• Pre-installed folders are deleted if are configured as 'not deployed' (other scenario IMHO)
• Extra configuration is copied when is provided as file or template under playbook_dir

Additional Information

Goss

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

All the documents should refer to Idealista S.A instead of Idealista S.A.U

Prerequisites

• [X ] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

I want to change the path of the log files to another directory like '/var/log/tomcat/' or something else.

Expected behavior: With a variable I want to set the log files destination.

Actual behavior: Once installed, the log files are placed in "{{ installation_path }}/logs"

Versions

All versions

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Due to the inclusion of verify_checksum argument in maven_artifact module in Ansible 2.6 (https://docs.ansible.com/ansible/2.6/modules/maven_artifact_module.html#verify_checksum), the module doesn't verify the checksum of the WAR if it is already downloaded by default, making it impossible to update it if the artifact_id is identical.

Steps to Reproduce

1. Use the role with Ansible 2.6 to download a war from a repository.
2. Make changes in such WAR.
3. Run the role again.

Expected behavior: The WAR to be updated.

Actual behavior: The WAR is not updated.

Reproduces how often: Always

Versions

All.

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Add an option to remove manage, host, examples and docs folders from webapps

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Following the Ansible Role name standards, this role should be renamed to "tomcat_role" instead of "tomcat-role".

Prerequisites

• [ X] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Need to add the option to add environment variables as the same way we can configure the catalina_opts variable.

Expected behavior: Add a variable in the configuration (main.yml or whatever) and configure the tomcat instance to use it.

Actual behavior: Not able to pass the variable and I must to add additional steps to configure the tomcat instance.

Reproduces how often: Allways

Versions

All

The version/s you notice the behavior.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

TASK [tomcat : Tomcat | Copy extra tomcat config templates (provided by playbooks)] ********************************
failed: [target.cont] (item=playbooks/templates/tomcat/conf/context.xml) => {"failed": true, "item": "playbooks/templates/tomcat/conf/context.xml", "msg": "Unable to find 'playbooks/templates/tomcat/conf/context.xml.j2' in expected paths."}

Steps to Reproduce

1. Create a templates/tomcat/conf directory
2. Add any file no matter extesion
3. The roles is not able to copy the file it always tries to add a ".j2" at the end of the file.
   https://github.com/idealista/tomcat-role/blob/c1c18e3787996819e11c6d880f66c8b2c632755c/tasks/config.yml#L28

In config.yml, lines 16 and 26, if there's any change, they don't notify the restart handler. This should be changed, as any new configuration should restart (or maybe just reload) the server.

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Maven Downloaded war belongs to root

Steps to Reproduce

1. Enable maven war downloaded
2. Download any war from maven
3. webapps/any.war user and group is root

Expected behavior: Download war should belongs to tomcat_userand tomcat_group

Actual behavior: war belongs to current ansible task runner (usually root)

Reproduces how often: Always

Versions

1.3.0

Description

In https://github.com/idealista/tomcat-role/blob/master/defaults/main.yml#L4 the tomcat version is 8.5.28 and the latest is 8.5.29 (http://tomcat.apache.org/tomcat-8.5-doc/changelog.html#Tomcat_8.5.29_(markt)).

Update the role to use the latest version due to use the improvements showed in changelog.

Description

In https://github.com/idealista/tomcat-role/blob/master/defaults/main.yml#L4 the tomcat version is 8.5.24 and the latest is 8.5.28 (http://tomcat.apache.org/tomcat-8.5-doc/changelog.html#Tomcat_8.5.28_(markt)).

Update the role to use the latest version due to use the improvements showed in changelog.

Prerequisites

• [X ] Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
  • Checked that there is not already provided the described functionality

Description

Molecule 3.x is now stable and may be a good idea to update this role to it.
https://molecule.readthedocs.io/en/latest/

Versions

1.8.0