idnan / furnish-js Goto Github PK

I know that this is opinion-based, but I would like to provide a little list of arguments on why this module is a bad idea. It is okay for experimenting, but please do not use this in production.

• MutationObserver used in this module is not supported by older browsers and there is no backwards-compatibility implemented.
• Instead of changing rules in your CSS file, you are now changing class names in HTML elements. What is the benefit of that? It is the same work.
• This is basically inline css. Let's say you want to update padding from p10 to p15. You have to update every element individually, because there is no external stylesheet anymore.
• By default this module inspecting and observing every DOM node. Browsers already do that by default. Why the extra work?
• It absolutely does not fit in modern development workflows (CSS preprocessors + watch + livereload).

Hi,

This is great but I could not get it to work. I tried including the min and regular js but attaching classes in your format didn't affect styling in Chrome or Firefox.

Maybe I'm missing something?

Hi,

I love the idea behind this, and I have a suggestion. In my opinion, it would be cool to use this as a preprocessor that takes an HTML file as input, and generates output CSS with only the required classes. That way it could be used as a Grunt/Gulp task and the runtime footprint would be even smaller.

What do you think?

I'm just wondering why not make every style end up with !important to force the class since the developer is looking mostly for fast aligning solution to manage his DOMs

Hi,

Loading the min js crashes firefox - error's that the script has stop responding. When I remove it my site loads fine.