Giter VIP home page Giter VIP logo

Comments (6)

iffy avatar iffy commented on August 26, 2024 1

@peterkrieg the author of electron-updater says that private GitHub repos don't work. Glad you got S3 going!

from electron-updater-example.

develar avatar develar commented on August 26, 2024

electron-userland/electron-builder#1370

Do you recommend pursuing the Github method, or using simple http-server (somehow making that private?)

If you mean that your user will somehow use credentials to update, then yes, you need custom server. Use headers to pass auth data.

Or you can investigate if authenticated s3 suitable for you and file issue to support it.

from electron-updater-example.

peterkrieg avatar peterkrieg commented on August 26, 2024

Thanks for the quick response @develar !

So, I actually got it to work where auto updater detects there is an update available, but then fails to actually download it. Does this mean the authentication with Github is working, or there is still something going wrong?

I got the auth with private repo to work by using the autoUpdater.setFeedURL() method before calling checkForUpdates(), as discussed in this issue.

This is the error I see when using electron-log:

[2017-06-01 11:48:37:0733] [info] Checking for update
[2017-06-01 11:48:38:0607] [info] Found version 2.1.12 (url: https://api.github.com/repos/ic-software/electron-review-tool/releases/assets/4007648)
[2017-06-01 11:48:38:0608] [info] Downloading update from https://api.github.com/repos/ic-software/electron-review-tool/releases/assets/4007648
[2017-06-01 11:48:39:0355] [warn] Error: Update download failed. The server sent an invalid response. Try again later.

I'm wondering if this is still an issue with Github authenticating, or if it is a completely separate issue with autoUpdater I'm experiencing.

from electron-updater-example.

peterkrieg avatar peterkrieg commented on August 26, 2024

Update: I got auto-updating working with simple HTTP request over amazon S3.

I never did get auto-updater to work with private Github repos. If someone has a solution I'm still curious to see it, but otherwise this thread can be closed, thanks!

from electron-updater-example.

p3nGu1nZz avatar p3nGu1nZz commented on August 26, 2024

@peterkrieg @iffy i got this working fine with 2 repos (one private one for source code, and public one with just releases no source code). In the root of my package.json I added

"repository" : { 
    "type" : "git", 
    "url" : "https://github.com/my-app-release.git"
  },

i just named the repos the same but appended -release to the public release repo

from electron-updater-example.

naheller avatar naheller commented on August 26, 2024

@1-14x0r a two-repo setup like this would be ideal for me. is your -release repo completely empty except for the release artifacts?

from electron-updater-example.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.