igloo-be / cf-curl Goto Github PK

e.g.

public cUrl function init(required string target, struct options) {
	...
	structAppend(variables, arguments.options);

    return this;
}

To reproduce just call test.cfm in ACF 11, 2016 or 2018.
Error in _match function, line
res.add(m.group(i));

Just downloaded the project and attempted to run the test.cfm file but the tests fail:

Error:
Variable RES is undefined.

Environment:
Apple MacOS
Adobe ColdFusion 2016 (2016.0.10.314028)
CURL 7.64.1 (Brew Install)

When I dump 'cURL.exec()' the object comes back as undefined.

Many WAFs are configured to block access if the username is empty or if it contains "CURL".

Please add support for specifying a custom user-agent as well as a default user agent.

I've added a default value to the public init function:

variables.useragent = "cf-curl";

and then added this logic to to the private _commandArg function.

if(len(trim(variables.useragent))){
    c.add('-A "#variables.useragent#"');
}

variables.processIsExited is defined but never used?

variables.isExited is defined but not used?

"else if( isExited )" condition in cfthread throws an error, because isExited is not defined?

See
https://trycf.com/gist/f303dd5bf0a815653b1cfbe04175c5c9/lucee5?theme=monokai
3-4 times slower the cfhttp?

HTTP Call
count 1: 655 milliseconds
count 2: 625 milliseconds
count 3: 649 milliseconds
count 4: 614 milliseconds
count 5: 716 milliseconds
count 6: 636 milliseconds
count 7: 666 milliseconds
count 8: 792 milliseconds
count 9: 614 milliseconds
count 10: 686 milliseconds

CURL Call
count 1: 2707 milliseconds
count 2: 2677 milliseconds
count 3: 2641 milliseconds
count 4: 2626 milliseconds
count 5: 2612 milliseconds
count 6: 2579 milliseconds
count 7: 2586 milliseconds
count 8: 2621 milliseconds
count 9: 2581 milliseconds
count 10: 2621 milliseconds

I encountered a "No group with name <1>" parser error when using ColdFusion 2106u15 with the private _match function.

This:

     res.add(m.group(i));

should be

     res.add(m.group(javacast("int", i)));

Hi,

Is it possible for you to add a license to this repository? We would like to be able to use this code but since it has no license, nobody is allowed to copy or modify it.

See https://choosealicense.com/no-permission/

Thanks!

A bit of a weird one here.

I am using lucee and have discovered that the implementation of thread has an intermittent problem.
It's a known issue, but was wondering if the cfc could have an option to not use thread when it comes to the _exec function.
Or, can someone help me rewrite the function without using thread?