Comments (4)
This what WebsocketEventAlt
and StreamEvent
are for originally. You already have the receive the channel in 'StreamEvent' when you parse the event.
As you can see, there is another stream event you missed which is the partial depth stream that yields an OrderBook
from binance-rs-async.
I agree that having a single data type is superior, but this is at the cost of additional bytes that add no direct value since the information is already encoded in the enum type, let me try to hack a bit at your PR to see if we can get rid of this problem.
from binance-rs-async.
Yes, I didn't notice the StreamEvent and WebsocketEventAlt type. so I think the original implementation is fine.
from binance-rs-async.
Well, I think you are right design wise, but performance wise the original one will be slightly nimbler. However you made a good point so I will improve upon your PR and add a few methods in the websockets impl to add combined streams as well.
from binance-rs-async.
Related Issues (20)
- Stop Loss Orders & Take Profit Orders for futures HOT 3
- NOT working - get_exchange_info HOT 1
- Support Universal Transfer HOT 5
- Add cargo crate URL to github repo description HOT 1
- Crates.io description says async-std, when the Tokio is used HOT 4
- To support proxy connection to binance websocket HOT 6
- Fix: wallet api bugs HOT 12
- Margin Account cancel_all_orders on open OCO order yields MarginOCOOrderResult instead of MarginOrderCancellationResult HOT 6
- add PartialEq on OrderStatus and similar types HOT 1
- errors while using the wallet feature? HOT 2
- Is futures websocket stream not implemented? HOT 10
- futures position_information implementation HOT 1
- The GET method internally creates a new `reqwest::Client` each time.
- Configure timeout of the client. HOT 5
- Dependency Dashboard
- Proxy support? HOT 11
- Version 1.3.2 didn't match with the available ones HOT 2
- Signature for this request in not valid HOT 2
- How to solve recvWindow error?
- tokio-tungstenite updating to version 0.20 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binance-rs-async.