Giter VIP home page Giter VIP logo

Comments (4)

Igosuki avatar Igosuki commented on June 14, 2024

This what WebsocketEventAlt and StreamEvent are for originally. You already have the receive the channel in 'StreamEvent' when you parse the event.
As you can see, there is another stream event you missed which is the partial depth stream that yields an OrderBook

from binance-rs-async.

Igosuki avatar Igosuki commented on June 14, 2024

I agree that having a single data type is superior, but this is at the cost of additional bytes that add no direct value since the information is already encoded in the enum type, let me try to hack a bit at your PR to see if we can get rid of this problem.

from binance-rs-async.

 avatar commented on June 14, 2024

Yes, I didn't notice the StreamEvent and WebsocketEventAlt type. so I think the original implementation is fine.

from binance-rs-async.

Igosuki avatar Igosuki commented on June 14, 2024

Well, I think you are right design wise, but performance wise the original one will be slightly nimbler. However you made a good point so I will improve upon your PR and add a few methods in the websockets impl to add combined streams as well.

from binance-rs-async.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.