Merging with community development about ingress-intel-total-conversion HOT 39 OPEN

Hi.
Have you seen this earlier attempt to adopt community PRs?
https://github.com/Sinnohd/ingress-intel-total-conversion

There is another alive fork: https://github.com/McBen/ingress-intel-total-conversion
(there is updated leaflet, among other changes)

from ingress-intel-total-conversion.

@johnd0e Hi. Thank you, https://github.com/Sinnohd/ingress-intel-total-conversion is not seen, but if I understand correctly, there is only adopt community PRs.

And https://github.com/McBen/ingress-intel-total-conversion repository saw, with its help updated the mobile application.

from ingress-intel-total-conversion.

but if I understand correctly, there is only adopt community PRs.

Yes.

with its help updated the mobile application.

As I can see, McBen's fork is oriented more toward desktop iitc.
I tried mobile version from that sources and there were some problems with McBen's additional menu (may be I did it wrong, though).

from ingress-intel-total-conversion.

BTW, there are more useful ideas.
E.g. see https://github.com/inok6743/iitc, where whole iitc can be (auto)built via Travis CI.

from ingress-intel-total-conversion.

and there were some problems with McBen's additional menu

You can test the application I built from my repository https://play.google.com/store/apps/details?id=org.exarhteam.iitc_mobile

Deploy via Travis CI is very interesting, thanks

from ingress-intel-total-conversion.

You can test the application I built from my repository https://play.google.com/store/apps/details?id=org.exarhteam.iitc_mobile

Thanks, iitc in material design looks great!

from ingress-intel-total-conversion.

Consider these externals updates:
Bing: McBen@3d83d8c
KML: McBen@db2ac16
autolink: McBen@a96dce1

Another map tiles set:
McBen@c2ed293

These small fixes to plugins:
bookmarks: McBen@42935b7
uniques: McBen@aa19314

These big changes:
scoreboard: https://github.com/McBen/ingress-intel-total-conversion/blob/master/code/dialog_region_scoreboard.js
cross_link: https://github.com/McBen/ingress-intel-total-conversion/commits/master/plugins/cross_link.user.js
though not sure if last two is finished (and may be there are more commits)

--
iitc-project/ingress-intel-total-conversion#1314

from ingress-intel-total-conversion.

Some other features I was able to find in McBen's fork:

• layers grouping
• separate menu for plugins entries (instead of portal info view)
• webpack build-system (unfinished)
  • local node fileserver

from ingress-intel-total-conversion.

• RegionScoreboard improved #1045 [needs improvement]

Note: McBen does not update that branch anymore, it is now merged in McBen/ingress-intel-total-conversion/master (and it still continues to update).

from ingress-intel-total-conversion.

[x] Fix. Touch events default passive to false #1261

It appears checked, but in fact I am unable to see corresponding changes in sources.
(As I understand, that PR is unlikely needed after leaflet update)

from ingress-intel-total-conversion.

PR is unlikely needed after leaflet update

I agree, update Leaflet should correct the error. However, I have worked before)

from ingress-intel-total-conversion.

But question is: have you merged that PR here, in master?

from ingress-intel-total-conversion.

No, just updated leaflet

from ingress-intel-total-conversion.

No

That's what I'm telling about.
But in first message of this issue this PR looks like merged:

[x] Fix. Touch events default passive to false #1261

So I suppose we should clear check mark (or even remove that item).

from ingress-intel-total-conversion.

I edited the list, added an comment that corrected by update Leaflet

from ingress-intel-total-conversion.

• Fix Intel Map URL #1291

Do we need it after 0f03130?

from ingress-intel-total-conversion.

Do we need it after 0f03130?

Yeah, do not need

from ingress-intel-total-conversion.

• enable click in portalinfo on smartphone #1125

Also should be removed from the list: as it reverted by 2b37b00

from ingress-intel-total-conversion.

• New tiles steamen #1283

We do not need this patch, because old plugin still works just fine.
I have another patch #74 (very minor enhancements).

from ingress-intel-total-conversion.

• New tiles nokia #1282

I do not think that we should include this plugin, as the tiles are not free anymore.
We can't abuse demo credentials included in code.

from ingress-intel-total-conversion.

• New tiles nokia #1282

I do not think that we should include this plugin, as the tiles are not free anymore.
We can't abuse demo credentials included in code.

Why not inlcude this plugin with a request for the needed data.
THe Plugin works for me without any problem.
And there are serveral people which have an account there ;)

from ingress-intel-total-conversion.

@gusowski1

HERE service is great, I agree.
I even have my personal plugin for it, with extended parameters.

But we can't include demo credentials.

from ingress-intel-total-conversion.

@modos189
Don't you mind if I slightly reorder points in your list of patches?

from ingress-intel-total-conversion.

Ok)

from ingress-intel-total-conversion.

It appears that there are useful PRs even among closed, e.g. author:michaeldever.

And may be it's even worth to check some private branches, like https://github.com/michaeldever/ingress-intel-total-conversion/commits/dialog-buttons

from ingress-intel-total-conversion.

• draw tools: save color in localStorage #1238 by AlterTobi
• Documentation updates to some portal and entity functions #1128 by richseviora
• Adding support for outputting MaxField-friendly list #1108 by adiov
• Add the GSI of Japan map tiles plugin #1106 by TsudaKageyu
• Use placeholders for cached portals #1042 by MNoelJones
• Update draw-tools.user.js #1022 by ckanoab
• Create show-portals-i-own.user.js #1014 by leo5374 (will not accept)
• Draw Projects #1005 by ZasoGD
• author:pleasantone
  • Copy portal to clipboard #1194
  • Better UI hiding mechanism (uses Alt-H) #1193
  • Make cross-links easier to identify #992 seems the same as #1191
  • Summary count of portals in list #991
  • Filter portal list by polygon if present and visible #990 and portals list level summary and portals list filter by polygon #983 seems the same as #1190
• Export bookmarked portals to a CSV lists #948 by arnaudNYC
• Added Plugin to remove portal resizing #924 by Spontifixus
• Added visited/captured (anti?)highlighters #920 by 3ch01c
• Waze Map Link #908 by umer936
• [portals export] Initial commit #897 by VBelozyorov
• Uniques: add ability to track owned portals #887 by lapo-luchini
• Add keyboard shortcut for adding/removing keys #836 by danmana appears same as #855
• Adding plan locking and Draw Tools integration to Fly Links #812 by jokedst
• Fix typos in plugin descriptions #798 by dpursehouse (see #110)
• Update "Bookmarks". New "Portals Exporter" #397 by ZasoGD
• portals-list not working on zoom less than 15 #1281 by alcr

--- E:/portals-list.user.js	Ср окт 31 13:38:12 2018
+++ E:/portals-list_alcr-mod.user.js	Ср окт 31 14:07:53 2018
@@ -67,8 +67,8 @@ window.plugin.portalslist.filter = 0;
 window.plugin.portalslist.fields = [
   {
     title: "Portal Name",
-    value: function(portal) { return portal.options.data.title; },
-    sortValue: function(value, portal) { return value.toLowerCase(); },
+    value: function(portal) { try { return portal.options.data.title; } catch(e) { return e.message;}; },
+    sortValue: function(value, portal) { try { return value.toLowerCase(); } catch(e) { return e.message;}; },
     format: function(cell, portal, value) {
       $(cell)
         .append(plugin.portalslist.getPortalLink(portal))
@@ -77,7 +77,7 @@ window.plugin.portalslist.fields = [
   },
   {
     title: "Level",
-    value: function(portal) { return portal.options.data.level; },
+    value: function(portal) { try { if (portal.options.data.level) return portal.options.data.level; else return 0; } catch(e) { return 0;};},
     format: function(cell, portal, value) {
       $(cell)
         .css('background-color', COLORS_LVL[value])
@@ -87,7 +87,7 @@ window.plugin.portalslist.fields = [
   },
   {
     title: "Team",
-    value: function(portal) { return portal.options.team; },
+    value: function(portal) { try { return portal.options.team; } catch(e) { return 'ERR';};},
     format: function(cell, portal, value) {
       $(cell).text(['NEU', 'RES', 'ENL'][value]);
     }
@@ -94,8 +94,8 @@ window.plugin.portalslist.fields = [
   },
   {
     title: "Health",
-    value: function(portal) { return portal.options.data.health; },
-    sortValue: function(value, portal) { return portal.options.team===TEAM_NONE ? -1 : value; },
+    value: function(portal) { try { if (portal.options.data.health) return portal.options.data.health; return 0; } catch(e) { return -2;}; },
+    sortValue: function(value, portal) { try { return portal.options.team===TEAM_NONE ? -1 : value; } catch(e) { return -2;}; },
     format: function(cell, portal, value) {
       $(cell)
         .addClass("alignR")
@@ -105,7 +105,7 @@ window.plugin.portalslist.fields = [
   },
   {
     title: "Res",
-    value: function(portal) { return portal.options.data.resCount; },
+    value: function(portal) { try { return portal.options.data.resCount; } catch(e) { return -1;}; },
     format: function(cell, portal, value) {
       $(cell)
         .addClass("alignR")
@@ -115,8 +115,8 @@ window.plugin.portalslist.fields = [
   },
   {
     title: "Links",
-    value: function(portal) { return window.getPortalLinks(portal.options.guid); },
-    sortValue: function(value, portal) { return value.in.length + value.out.length; },
+    value: function(portal) { try { return window.getPortalLinks(portal.options.guid); } catch(e) { return -1;}; },
+    sortValue: function(value, portal) { try { return value.in.length + value.out.length; } catch(e) { return -1;}; },
     format: function(cell, portal, value) {
       $(cell)
         .addClass("alignR")
@@ -128,7 +128,7 @@ window.plugin.portalslist.fields = [
   },
   {
     title: "Fields",
-    value: function(portal) { return getPortalFieldsCount(portal.options.guid) },
+    value: function(portal) { try { return getPortalFieldsCount(portal.options.guid) } catch(e) { return -1;}; },
     format: function(cell, portal, value) {
       $(cell)
         .addClass("alignR")
@@ -139,11 +139,13 @@ window.plugin.portalslist.fields = [
   {
     title: "AP",
     value: function(portal) {
+      try {
       var links = window.getPortalLinks(portal.options.guid);
       var fields = getPortalFieldsCount(portal.options.guid);
       return portalApGainMaths(portal.options.data.resCount, links.in.length+links.out.length, fields);
+      } catch(e) { return portalApGainMaths(0, 0, 0);};
     },
-    sortValue: function(value, portal) { return value.enemyAp; },
+    sortValue: function(value, portal) { try { return value.enemyAp; } catch(e) { return -1;}; },
     format: function(cell, portal, value) {
       var title = '';
       if (teamStringToId(PLAYER.team) == portal.options.team) {
@@ -378,6 +380,7 @@ window.plugin.portalslist.portalTable = function(s
 //               double click: zoom to and select portal
 // code from getPortalLink function by xelio from iitc: AP List - https://raw.github.com/breunigs/ingress-intel-total-conversion/gh-pages/plugins/ap-list.user.js
 window.plugin.portalslist.getPortalLink = function(portal) {
+  try {
   var coord = portal.getLatLng();
   var perma = '/intel?ll='+coord.lat+','+coord.lng+'&z=17&pll='+coord.lat+','+coord.lng;
 
@@ -396,6 +399,9 @@ window.plugin.portalslist.getPortalLink = function
     return false;
   });
   return link;
+  } catch (e) {
+    return e.message;
+  }
 }
 
 window.plugin.portalslist.onPaneChanged = function(pane) {

from ingress-intel-total-conversion.

• New tiles thunderforest #1284

The service is not free now, so we can't include it with IITC.

I see there are many such services.. May be we could provide them on separate page.

from ingress-intel-total-conversion.

Some code to look:

• Settings class: johnd0e/iitc-McBen@36996d8
• fixed chrome on ubuntu font problems: McBen@cf1d9da
  @modos189, could you confirm if it is useful or not?

from ingress-intel-total-conversion.

fixed chrome on ubuntu font problems

I don't understand why this change. It just breaks fonts.

from ingress-intel-total-conversion.

HackRange added to zapRange-plugin, renamed to Portal-Range

from ingress-intel-total-conversion.

#1014 not possible due to missing details form intel.

from ingress-intel-total-conversion.

#1014 not possible due to missing details form intel.

It is possible, but still against our policy (due to bulk requests).

from ingress-intel-total-conversion.

Sure. I recommend to close #1014

from ingress-intel-total-conversion.

I'm not sure if this would be the correct place to post a request, as I am not familiar with the code, I do have an Idea for the mobile version of IITC. I have a samsung gear S2 that I bought in the hopes on having Ingress on it.... NOPE. So I wonder as there is a browser in the watch, and it's linked to my phone by bluetooth, is there a way to have IITC running on my phone in the background, and the output sent to the watch ?? That way I could continue with ingress on the phone.

from ingress-intel-total-conversion.

@ph3arr3t This is an interesting idea, but it requires a person who has such a watch

from ingress-intel-total-conversion.

DrawTools: send the layerGroup when running edit and delete hooks #1049

from ingress-intel-total-conversion.

I have said watch, and am willing to assist in the development, I'm not so great with android OS or python..
watch model - SM-R720
Tizen ver. 2.3.2.7
software ver. R720XXU2FRC1
Storage cap. 4.0 gb

from ingress-intel-total-conversion.

Having an issue in understanding what johnd0e last posted..
was in IITC on phone, drew circle around avatar, tried to "send" to watch....
wasn't displayed as option, the watch is connected to phone via bluetooth, not sure if there is any function in IITC for recognition of BT connection. In browsing the repository I didn't see any.
Let's just make it easy, I'm obviously a noob to this.. can I get a more BASIC explanation as to how to do what was stated please..

from ingress-intel-total-conversion.

@ph3arr3t Please open separate issue to discuss your ideas.

from ingress-intel-total-conversion.