It was opaque before, I suppose the problem appeared after one of last commit, probably related to #3.

Actually, I already saw the same in McBen's fork.

Icons at draw panel seem blurry after update 68cf49f

Originally posted by @johnd0e in #3 (comment)

Returning via the system back key works

E.g. we are unable to send direct PRs to https://github.com/iitc-project/ingress-intel-total-conversion/
Co-operation with other forks gets harder too.

Some icons are extremely low-res and need to be enhanced/replaced.

Most important:

• Bookmark star from this sprite: bookmarks-img.png
• icon-bookmark.png, icon-bookmark-map.png
• marker-star.png
• current-location.png

Also:

• mission-length.png, mission-type-hidden.png, mission-type-random.png, mission-type-sequential.png, mission-type-unknown.png
• open-folder-icon_sml.png (add-kml)
  alt: https://github.com/makinacorpus/Leaflet.FileLayer/blob/master/docs/folder.svg

Externals:

• minimap-toggle.png
• pan-down.png, pan-left.png, pan-right.png, pan-up.png
• zoom-slider.png

Since Leaflet 1.0 there is buildin L.Tooltip functionality, which can be more powerful than IITC's own custom tooltips.

For example, it could be used in player-tracker in order to provide (optionally) permanent labels for players' nicks.

I saw some plugins capable of that, but their implementations are far from perfect (main issue: overlapping labels).

Some ideas where we may use tooltips:

• Portal info tooltip #195
• Portal permanent label (as replacement for portal-names plugin)
• Players' nicks for player-tracker

Background info:

• https://en.wikipedia.org/wiki/Restrictions_on_geographic_data_in_China#GCJ-02
• https://web.archive.org/web/20140116215242/http://home.wangjianshuo.com/archives/20081109_all_maps_in_china_are_transformed.htm

Summary: some map tiles providers use GCJ-02 coordinates, thus map appears with some offset.

Originally posted by @modos189 in https://github.com/_render_node/MDExOlB1bGxSZXF1ZXN0MjQ0Njc3OTI3/pull_requests/unread_timeline#issuecomment-454773564

After returning from hibernate mode I've got multiple alerts windows opened:
Plugin Sync error: undefined, undefined.

In plugin dialog I can see this log:

1:47:04 AM: Authorized
1:47:04 AM: Retry in 10 sec.: bookmarks[bkmrksObj]
1:47:04 AM: Drive API Error: undefined
1:47:04 AM: Authorized
1:47:04 AM: Retry in 10 sec.: bookmarks[bkmrksObj]
1:47:04 AM: Drive API Error: undefined
1:47:04 AM: Authorized
1:47:04 AM: Retry in 10 sec.: bookmarks[bkmrksObj]
1:47:04 AM: Drive API Error: undefined
1:47:04 AM: Authorized

In DevTools console I see a lof of errors like these:

content.googleapis.com/discovery/v1/apis/drive/v3/rest?fields=kind%2Cname%2Cversion%2CrootUrl%2CservicePath%2Cresources%2Cparameters%2Cmethods%2CbatchPath%2Cid&pp=0:1 Failed to load resource: net::ERR_NAME_NOT_RESOLVED
content.googleapis.com/discovery/v1/apis/drive/v3/rest?fields=kind%2Cname%2Cversion%2CrootUrl%2CservicePath%2Cresources%2Cparameters%2Cmethods%2CbatchPath%2Cid&pp=0:1 Failed to load resource: net::ERR_NETWORK_CHANGED
content.googleapis.com/drive/v3/files/1P8umW4139M9HPyNK5NF5ad_Oe1H4iI73?alt=media:1 Failed to load resource: the server responded with a status of 401 ()

In current code base we can see now a variety of different styles.
It would be great to bring everything to some common code style.

So let's discuss here:

1. Elements of iitc-code uniform style

2. Tools to implement style checking, and ways to include them in our CI-chain.

There are A LOT of plugins (some we can see in #2) with same demand:

• choose several portals for further processing
• or just limit processing objects to some area

Instead of re-implement the same functions in each plugin it would be very convenient if IITC provides this as utility function(s).

And more: imho existing implementations are not generic enough.
E.g.:

• there is ability to limit area with polygon, but no ability to exclude some portals.
• draw-tools can be used for area selection, then one of 'point-in-polygon' algorithm implementations: #552
• there are many other possible tools (see https://leafletjs.com/plugins.html#areaoverlay-selection)
  • rectangle
    • https://github.com/kajic/leaflet-locationfilter/
    • https://github.com/heyman/leaflet-areaselect
  • polygon
    • https://github.com/bopen/leaflet-area-selection
  • freeform
    • https://github.com/sandropibia/Leaflet.SelectAreaFeature/
    • https://github.com/zakjan/leaflet-lasso

So, the best solution would be to make objects selection tool as plugin.

Edit: this is actually not new idea: iitc-project/ingress-intel-total-conversion#736 (comment)

It would be convenient in order to search exact build where some regression occurred.
But we need to mark apk somehow, may be by appending sha-hash to it's name.

We should describe our development process (#56) in some document.

• iitc-project/ingress-intel-total-conversion#1297
• iitc-project/ingress-intel-total-conversion#1296
• iitc-project/ingress-intel-total-conversion#1295
• [fixed] iitc-project/ingress-intel-total-conversion#1271

Development has stopped in the main project, but third-party developers continue to improve IITC.

The goal of this project is to adopt useful Pull-Requests, and to continue the development of IITC with the provision of an updatable site, script and mobile application.

Prompt delivery of updates will soon be very important when Niantic is engaged in updating the Intel map.

You need to check these changes, and if they are good, then take the project:

Core

• Python Code Cleanup... #1072 by canardleteer
• build.py: loaderString should escape -characters? #762 by strguntbr
• Normalize build.py according to pep8 #861 by hashar
• Add @@PLUGINSTART-USE-STRICT@@ Replacement #1187 by hayeswise
• Fix .editorconfig for python indentation. #1263 by inok6743
• Use the new Gradle build system and update the target API to 21 #942 by zhaofengli
• Migrating IITC Mobile to SDK 28, fixed issues with new intel URL #1286 by mike-lambert
• JQuery 3.1.1 update #1173 by McBen
• Spread requests over all available buckets #1131 by ah42
• Use dialog() consistently to only allow one instance of each dialog to be open #921 by nexushoratio
• Move and zoom to portal double clicking its title #1087 by Dron007
• change portalDetail.request to return a jQuery promise #1163 by terencehonles
• Improve NOMINATIM search by including viewbox bounds #1246 by nhamer
• preview selected search result on hover #1247 by nhamer
• iOS version of IITCm #1037 by HubertZhang
  • add detection for iOS #1025 by HubertZhang
• Allow offical plugins to be searched on mobile app #1232 by IamTechknow [needs improvement]
• RegionScoreboard improved #1045 by McBen [needs improvement]
  Continued here: https://github.com/johnd0e/iitc-McBen/blob/master/code/dialog_region_scoreboard.js
  • Show total team scores together with checkpoints overview #1003 by VBelozyorov

Fixes

• Greasemonkey/firefox 58 compability #1249 by McBen
• adjust links #828 by argrath
• Bookmarks: update location of highlighter dropdown #1098 by tsager
• Fix: Portal level layer strikeout #1174 by McBen
• Fix crash when sharing on some devices #1227 by PurkkaKoodari
• Typosquat #1250 by wschoot
• data not defined on passcode failure means exception and no feedback #1254 by nhamer
• added a proper handling for the link defense boost attribute #1257 by auguchanan

Not needed / reverted

• Fix. Touch events default passive to false #1261 by ReinRaus [Fixed by update leaflet]
• enable click in portalinfo on smartphone #1125 by HubertZhang reverted by 2b37b00
• Fix Intel Map URL #1291 by lm9 [not need anymore]

Plugins:

New

• AP Gain breakdown plugin #352 by languantan
• added reverse geocoding in portal details #810 by tom-eagle92
• New plugin missing links #882 by rvandam
• New IITC plugin to show field areas for a given portal #934 by bricemciver
• New plugin: Copy portal name and links to clipboard #935 by tapionx
• New Plugin: Hide UI #1000 by MrR0bo7
• Hackrange PlugIn Script #1001 by gibberin
• Areas under attack plugin #1008 by bryndavies
• Variation of reso energy % for days remaining #1038 by ravendarque
• Add initial version of showtheway plugin #1113 by ariefwt
• Add a timestamp to the bottom right corner of the map #1192 by pleasantone
• New plugin: Show traffic lights #1225 by ivanpetrushev
• [?] Added new plugin extend-poly-lines.user.js #1138 by TheSned
  Updated version is on the web: https://github.com/TheSned/IITCPlugins/commits/master/extend-poly-lines.user.js
• [?] New plugin that allows the user to pick portals to be used as input for the maxfield script #1029 by rspielmann
  Need to check if this is better than IITC-Ingress-Maxfields-Exporter

Enhancements:

• [keys] add accesskey shortcuts for incrementing/decrementing key count #855 by danmana
• Sync, keys and keys-on-map: Implement the "Capsule concept" for portal keys #1160 by IIGhouLII
• score-cycle-times: adds dialog with all checkpoints in current cycle #859 by golesny
• score-cycle-times: Remove seconds, regardless if it has AM/PM or not. #968 by imsaguy
• Fly-links: Region selection with the draw-tool plugin #1084 by Fly33
• Portal counts plugin will show the amount of resonators as well #1089 by schoentoon
• Change visited neutral portal fill when uniques are highlighted #1119 by benjamincuningham
• Update portal-highlighter-portal-ap.user.js #1135 by swined
• Portals-list fix #1169 by McBen and Add mapZoomHasPortals and additional JSDoc #3 by hayeswise
• Add drawtools support and improve portal list display #1190 by pleasantone
• Add HOOK to "userLocation" plugin #1177 by ZasoGD
• Fix a typo in plugins/regions.user.js #1213 by felixonmars
• [Canvas] Specify order so Scriptish Load Canvas before IITC by specifying run-at #947 by MikePach [not need anymore]
• Add ability to change how far each button press will pan #918 by nexushoratio

bookmarks-by-zaso

• Bookmark util functions #994 by reckter
• Add new bulk star/unstar/toggle feature #881 by nexushoratio
• Polyline fields in AutoDraw #969 by kottt / add an option to draw polylines instead of polygons #1075 by tony2001 / choose polygon vs. polyline with three portals selected in Auto Draw #1027 by ianmcorvidae
• Sort folders and bookmarks alphabetically by name #1015 by dandan
• merge bookmarks on import/paste #1220 by xscreach
• escape Unicode sequences when copying bookmarks #1031 by tony2001
• Google Maps route #851 by umer936
• ? Modified bookmarks plugin to allow copy/paste/import/export by folder [#846]iitc-project/ingress-intel-total-conversion#846) by 3ch01c

draw-tools

• Update draw-tools.user.js #1033 by ATXadam
  (Add Merge option to allow pasting of new draw tools in existing draw tools memory)
  Added “Paste and Keep Data” feature to draw tools plugin #914 by markfguerra
• Correct import issue with (new) standard intel #1290 by EvoldicA
• draw-tools: Remove duplicate links in copy URL #1270 by nheir
• Strip invalid characters from beginning and end of pasted strings #1242 by retsoksirhc

cross_link

• Cross-Links Sidebar Panel #1059 by ckanoab
• Cross Links: Filter 'crossing links' by color #903 by splee
• Added cross layers checks to cross-links plugin #1073 by dodomorandi / Update cross_link.user.js #1107 by Heistergand
• Add a wider color band around cross-links #1191 by pleasantone
• [cross_link] improved collision test algorithm https://github.com/johnd0e/iitc-McBen/commits/master/plugins/cross_link.user.js

player-tracker

• Update player-tracker.user.js #975 by SteelToad
• Different colours for ENL and RES ant-trails #1091 by zinob
• Player-names in players-tracker #1077
  • Update player-tracker.user.js #1196 by kddmitry
  • https://gist.github.com/neon-ninja/c51dd249b214a1f88027 by neon-ninja
  • https://gist.github.com/neon-ninja/0ef22dae138d31604983 by neon-ninja

Maps

• Added support for Google road map with traffic layer #1070 by d-m-wilson
• 5170a6d
  Fix kartverket layers #1288 by gusowski1/ Basemap-Kartverket: Added two different sets of tiles #1006 by sollie
• 8e8c2bc
  Modify "China" boundary for offset fix plugin #1188 by Artoria2e5
• c65895d
  Add Chinese Gaode Map base layer #1211 by mutongx / Create HD-gaode-XACXAN.user.js #1262 by sion934
• [?] New tiles nokia #1282 by gusowski1 (see #228)
• [?] New tiles thunderforest #1284 by gusowski1 (see #228)
• OpenStreetMap.se (Tjänster) map tiles johnd0e/iitc-McBen@c2ed293
• New tiles steamen #1283 by gusowski1 old plugin still works just fine

iitc writes a lot of debug info to console log, but it's not useful for general use, and only adds 'noice' to log.
It would be more useful if such thing were wrapped in something like this:

function window.debug.log (info) {
  if (window.debug.ENABLE_LOG) {
    console.log (info)
  }
}

Condition could be more complex:

function window.debug.log (level,info) {
  if (debug.ENABLE_LOG.ALL or debug.ENABLE_LOG[level]) {
    console.log (info)
  }
}

In order to control the condition ENABLE_LOG we could use additional plugin.

Edited

Unable to reinstall apk with changed signature.
The problem appeared after uninstalling previous build truing to keep it's data with this command:

adb uninstall [-k] <package> - remove this app package from the device
                               ('-k' means keep the data and cache directories)

Please help.

In many places of code with inline include (@@INCLUDERAW...@@) I see patterns like this:

try { console.log('Loading included JS now'); } catch(e) {}

We have here a bunch of 'issues' already. And I'm going to post more and more ideas there.

We should somehow arrange them, labeling as bug/feature/idea, plugin/core/development, etc.

Currently we have separate sub-directory with all upstream 'externals' (+ separate images subdirectory)

Most of them described in ATTRIBUTION.md.
Some of them have version info inside, but most of them not.
Some of them are even modified for iitc special needs, but in order to know details we have to dig though unclear commit history.

It's a pain to maintain and update these sources.

So I propose:

• Update all 'externals' to current version

Then:

• To document somewhere (for each 'external'):
  • version
  • url to upstream
  • add some comments
    • purpose, and where in iitc it is used
    • why was this component chosen
• When updating write verbose commit message, incl. url / version info / hash.
• If the source was modified, then we should:
  • add original unmodified
  • apply modification(s) as a separate commit(s), with verbose messages explaining purpose of changes
  • in case of heavy modification: keep separate branch, or make a fork of original repo (could be hosted in https://github.com/IITC-CE/).
• Find a way to avoid source modification
  • extend the component in some official way (if possible)
  • monkey-patch at run-time
  • push changes to upstream (via PR)
    And in general:
• Avoid in IITC/plugins own code inline including of 3rd-party code (and images).
  Use @@INCLUDExxx-macros instead.

Related links:

• Remove customizations of third-party code library #1165
• Which Directory for Reusable Code? #1185

(Well, I think it's rather our goal manifest than an issue)

Currently IITC code is divided by source files, but still not organized well enough, as different parts are not encapsulated, and all inter-dependencies are not obvious.

All IITC-specific objects now resides in global window namespace, polluting it with multiple rather chaotic entities, and it's often hard to identify where they come from (which source file, or may be even from stock intel?).

Even more: namespace is now heavily polluted with IITC's private functions, which are never meant to be exposed (e.g. because it's impossible to reuse them).

So I propose:

• Hide all private stuff, expose only that we are really in need.
• Transform each source file into independent module with own namespace.
  Use IIFE everywhere (like in entity_decode.js, portal_detail.js).
• Put all IITC objects into single IITC namespace object.

I believe that IITC own code should be exemplary, in order to facilitate clean and easy plugin writing for the whole community.
(Here is closely related issue: #46)

It's 2019, and ES2015+ features supports is getting better among modern browsers.
Several patches from #2 already using some (mostly let/const).

So it would be great if we decide which of the features are 'safe' to use in whole project.
But to select particular features we need to consider target platforms of IITC, as some of them could be limited.

Perhaps most universal approach would be to:

• Include some transpilling tool in our build chain.

error starting plugin: index 27, error: TypeError: L.Google is not a constructor

We can do one of these:

• raw-include old Google plugin here.
• re-base this plugin on GoogleMutant
• include this gray version in core (drawback: layer chooser gets overfilled)

Some things are not obvious and should be documented somewhere.

In fact IITC core may be loaded before plugins, after plugins, or somewhere in the middle.
Although in some environments we could control the order, but if scripts are loading asynchronously, then bigger scripts will finish loading later (no matter of initial order).

So in general we can't expect particular order of IITC/plugins loading.

But plugin's function setup is called when iitc is booted, and we can rely on this.

So the rule:
Plugin can use all service API's (IITC/jQuery/Leaflet/...) only after setup called

VM2568:433 Uncaught TypeError: Cannot read property 'naturalWidth' of undefined
    at HTMLDivElement.<anonymous> (<anonymous>:433:33)
    at HTMLDivElement.dispatch (<anonymous>:15833:41772)
    at HTMLDivElement.y.handle (<anonymous>:15833:39791)

As I understand this event handler in not meant to fire in mobile view mode, and here we see the (unsuccessful) attempt to turn it off:

Scripts that are building for iitc.modos189.ru should have updateURL/downloadURL in order to self-update.

Request write storage permissions only if you add scripts.

When I open *.user.js at Chrome webpage (or in file manager) it proposes list of applications.
I select IITC and after confirmation all seems ok, but then Plugins settings screen appears without user plugins.

There should be permission request, I suppose.

And I think this even will not be enough, consider this case:
IITC was once installed and we have user plugins in IITC-Mobile/plugins directory.
Then we uninstall apk, and install it again.
Will we get permission request?

Originally posted by @johnd0e in #4 (comment)

It is white.
And both it's buttons (map/clear) is also white, so it's hard to view them.

In 'official' iitc command line background color is dark, the same as background of console itself.

I have an idea how we could facilitate our development process, delivering new features faster, while keeping master branch clean, neat and stable.

So, what I propose:

1. master branch is only for stable builds with well-tested (in other branches) changes.
   Push to master means (auto)deploying new stable build.
2. For every new set of changes we use separate feature-branches (PRs), which should be made vs master.
   PRs are keeping open until final merging into master (it's possible to squash/rebase them to make history cleaner).
3. development branch is for early-merging of feature-branches, as they go.
   'Early' means that we could merge them not well-tested, then fix, remerge, (force)reset, etc, not bothering to keep history clean.
   • Cons: could be unstable.
   • Pros: features delivered earlier, which in turn let to test them thoroughly.
4. After we decide that feature is ready - we merge it into master, closing PR.

So instead of current test builds we get development builds (title is not important).

Main difference: there we could play with features more bravely, because we would not care about secondary things (such as clear history).

Currently IITC for desktop is updated automatically by GM/TM (well, after #32 resolved).

Mobile is also capable to update plugins, but only external.
So why do not update built-in scripts in the same manner?

In most cases it's enough to update scrips, and leave 'old' apk (well, there could be rare exceptions 0ae25e1).

Many included basemaps are looking not good enough, like low-res.
I suppose that it's possible to play with argument in order to improve maps.

Here will be the list with maps that have to be enhanced

• Bing
• Yandex
• ...

@modos189
Why have you removed attribution info from iitc About dialog?
9fe3e94

On start I've got only 1 permisson request: Location.
And there were no request about Storage access which is necessary e.g. for external plugins.

I was able to set the permission manually but it will be better if it requested on apk start.

After I've enabled the plugin I am unable to click at portal.

Apk from market does not have this issue, so I suppose it is caused by the very recent update, probably related to 68cf49f.

If using CartoDB maptiles set then console log contains many warning like this:

<no source>:12795: Mixed Content: The page at 'https://intel.ingress.com/intel?vp=m' was loaded over HTTPS, but requested an insecure image 'http://c.basemaps.cartocdn.com/dark_all/17/78347/45657.png'. This content should also be served over HTTPS.

I see this line in code:

Imho as nia restricted intel to https we do not need to support http.

P.S.
Perhaps there is a lot of http-stuff left in other places, need to check.

Regarding this patch: 59cc312

1. I am unable to see any icon (developer build).
   Perhaps there is some problem with svg rendering.
   Tried with different values of "Use Canvas rendering" option (btw McBen's fork does not have this
   option anymore)
2. When I click on empty space at left of the title - map actually moves and zooms, but user cannot see it
   until he closes portal view .
   Imho it would be more intuitive if porlal view gets closed automatically.

In debug build

When title is long enough (e.g.: Ceglie Messapica - Chiesa Di San Rocco) then it wraps on new line.

Title itself has white-space:nowrap style, so it wraps at whole, leaving on first line all other objects: location icon #ic_place_24px, and bookmark star (if plugin loaded).

The issue becomes more noticeable when Show linked portals is active (edit: fixed by 61ec254).

is there the ability to change the UI theme according to the faction? and who knows a redesign? ta well outdated, btw good work on reliving this beautiful project!!

I need access Plugins settings a lot more than any other setting item.
It would be convenient to have direct link to it in menu.
It may be optional (Advanced Settings / Configure IITCm menu).

I have several conceptual questions regarding functions naming etc.
So the 1st:

1. In all official plugins I see the same pattern of long-and-ugly namespace references, like window.plugin.showLinkedPortal.previewOptions (it's also inconsistent as somewhere there are references w/o window. prefix).

Shouldn't we fix it, like here: c1aec19?

I suppose it fails after leaflet update: 68cf49f (though unchecked).

test

Example: location icon in portalinfo.

Workin sample: http://jsfiddle.net/adamboduch/FFxZ3/8/

Plugin's sources now are not valid js code, because of build-time substitution blocks like @@METAINFO@@, @@PLUGINSTART@@, @@PLUGINEND@@.

It complicates applying such tools like eslint.

It would be great if we could rearrange the code to make the substitutions appear commented, e.g.

// @@METAINFO@@
// ...
// @@PLUGINSTART@@
// ...
// @@PLUGINEND@@

Originally posted by @modos189 in #12 (comment)

Please make some signature in order to let each new debug build to be installed over previous one.

In canvas mode _container property does not exist.

There are 2 ways to fix it:

1. As suggested in iitc-project/ingress-intel-total-conversion#1142, leaflet.draw should be updated.
   And related fix: iitc-project/ingress-intel-total-conversion#1244 (fix earth radius to same value used in leaflet and S2).
   More recents work on both issues is seen here: https://github.com/McBen/ingress-intel-total-conversion

2. There is alternative fix: iitc-project/ingress-intel-total-conversion#1261 (Touch events default passive to false).
   You can test it here: https://play.google.com/store/apps/details?id=com.cradle.iitc_mobile

• If attribution text is short it get completely covered by #updatestatus / #mobilestatus.
• If text is long then we can see some parts of it (which is actually even worse).

How we could fix it:

• Move attribution to 'topleft'.
  • It's not good for small screens
  • It's not trivial to place it along with other elements
  • Some maps use own control to display attribution, so it would require special handling.
    E.g. currently if we move attribution to 'topleft' and switch to Google map then we see:
    • Google own data (.gm-style-cc)
    • Leaflet attribution with outdated data from map that was active before Google's.
• Completely disable attribution control
  • It may be against TOS of some tile providers.
• Use some expandable control to show attribution, e.g.
  https://github.com/route360/Leaflet.CondensedAttribution, https://github.com/areichman/leaflet-responsive-attribution (like here https://docs.mapbox.com/help/getting-started/attribution/)

BTW, there was old issue: #865

1. IITC colors are ugly.
   I hate background color most of all.
   Shouldn't we use default palette from Ingress intel?

2. IITC css is chaotic.
   Currently in order to overdrive background I need to redefine a bunch of styles independently (instead of change just one value)

3. IITC UI elements themselves are placed without proper hierarchy.
   E.g. #sidebartoggle is not a part of #sidebar (or #scrollwrapper).
   #chat and #chatcontrols are also independent elements.
   So it's hard to theme them as whole part, and we get issues trying to change placing or scaling properties.

4. It's a common case in IITC if some complex element get completely cleared (or replaced, with all sub-elements). It's also undesirable in some cases, and it may be better to hide instead of clear (and update sub-elements individually, instead or rewriting whole parent element).

This is not new issue, but previously it was not important, because canvas mode was experimental and optional.

So, plugin has 5 different modes, and only 2/5 are usable now:

• Static
• Animate full link

Honestly, I do not think that all 5 are worthful (for me, the only useful mode was Static near origin).
May be we need to think about some different way of visualization.