@@-substitutions break validity of plugins' sources about ingress-intel-total-conversion HOT 7 CLOSED

I think that if not now, then in the future we will still be forced to use nodejs in the project. And if so, then let's add it now. Can you connect nodejs, babel and eslint to our build system? You seem to have more experience with this than I do.

from ingress-intel-total-conversion.

And if so, then let's add it now.

Why not. But in fact it is beyond of scope of this issue: here we need very minor change to build script (I can make PR).

P.S
Yes, in the end it's about nodejs-dependent tools, but at first we need to be able to use them locally.
Later (but only after we have all the sources prepared) we also could include linting/prettying in our CI pipeline.

Currently we also need node.js+babel in our build process in order to resolve #47 keeping backward compatibility, but is is separate issue.

You seem to have more experience with this than I do.

Actually I do not. But it seems not hard, so let's try)

from ingress-intel-total-conversion.

I've been building plugins with gulp and linting with eslint for a while, y simply inject code this way:
/* inject: ./src/folder/file.js */
or for html strings
someHTMLElement.html(`/* inject ./src/html/file.html */`)

i can send you the gulpfile and eslint files

from ingress-intel-total-conversion.

i can send you the gulpfile and eslint files

I'd like to see some samples, thanks in advance.

from ingress-intel-total-conversion.

i upload them here
build-files.zip

take a look

from ingress-intel-total-conversion.

The gulpfile and eslint files would need to be changed to match folders, also gulpfile will need changes to build plugins separatedly and IITC.

from ingress-intel-total-conversion.

@angel93ayora, thank you for samples.
I suppose we will transfer all our build system from python to node at some point.

As for this PR: I have new idea how we could completely get rid of all @@METAINFO/PLUGINSTART/PLUGINEND...
But it will be another PR.

from ingress-intel-total-conversion.