Comments (5)
The above is with current Desktop version IITC-CE v0.33.0 and 'Highlight portals missing resonators' plugin version 0.2.0.
Things look fine with Android Version 0.32.1 for some reason.
from ingress-intel-total-conversion.
Going back to old code fixes it for me.
0001-highlight-missing-resonators.js-fixes-issue-590.patch.txt
from ingress-intel-total-conversion.
From 0e07c62a59aa1372f2715a5fa48a54f878e47041 Mon Sep 17 00:00:00 2001
From: Stefan Dirsch <[email protected]>
Date: Mon, 17 Oct 2022 17:08:59 +0200
Subject: [PATCH] highlight-missing-resonators.js: fixes issue #590
Going back to old code fixes the issue for me ...
---
plugins/highlight-missing-resonators.js | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/plugins/highlight-missing-resonators.js b/plugins/highlight-missing-resonators.js
index 4eabbf94..6fd7583e 100644
--- a/plugins/highlight-missing-resonators.js
+++ b/plugins/highlight-missing-resonators.js
@@ -7,14 +7,6 @@
/* exported setup --eslint */
/* global L, TEAM_NONE */
// use own namespace for plugin
-var highlightMissingResonators = {};
-window.plugin.highlightMissingResonators = highlightMissingResonators;
-
-highlightMissingResonators.styles = {
- common: {
- fillcolor: 'red'
- }
-};
function missingResonators (data) {
@@ -23,13 +15,12 @@ function missingResonators (data) {
if (res_count !== undefined && res_count < 8) {
var fill_opacity = ((8-res_count)/8)*.85 + .15;
- // Hole per missing resonator
- var dash = new Array((8 - res_count) + 1).join('1,4,') + '100,0';
+ var color = 'red';
+ var params = {fillColor: color, fillOpacity: fill_opacity};
- var params = L.extend({},
- highlightMissingResonators.styles.common,
- {fillOpacity: fill_opacity, dashArray: dash}
- );
+ // Hole per missing resonator
+ var dash = new Array((8 - res_count) + 1).join("1,4,") + "100,0"
+ params.dashArray = dash;
data.portal.setStyle(params);
}
--
2.35.3
from ingress-intel-total-conversion.
So basically, the issue is about the portal not being red while missing resonators.
This is due to a typo in the code fillcolor
vs fillColor
from ingress-intel-total-conversion.
@le-jeu Thanks a lot! Sorry, I missed your PR. Removed mine. It was incomplete anyway as I see now when looking at yours ...
from ingress-intel-total-conversion.
Related Issues (20)
- Access blocked: authorisation error [Sync Error] HOT 8
- Mobile: Login with "fake user agent" switches to Desktop mode
- console warning is spamming HOT 2
- Gaode Map tiles is broken HOT 2
- Wrong region naming (and probably indexing) in the AS face HOT 2
- Pixel 8 Pro Not Working At All
- Migrate Stamen map tiles to Stadia HOT 1
- `Permalink` and `Portal link` are different than stock intel HOT 3
- Update Portal Count plugin to include History info
- Cell Score Names Wrong on Map HOT 1
- Login issues HOT 11
- [Not Working] - "Privacy view on intel" Offical Plugin
- Draw Tools update from 0.10.1 to 0.10.2 - menu is lost HOT 3
- Filtering portals by level doesn't work for Machina HOT 1
- Found 1 Fatal Exception Crash and 1 IllegalArgumentException from Testing
- Permalink menu entry broken since v38.0
- AP gain calculation does not include Machina recapture 1331 bonus
- __MACHINA__ is part of RES on guess player level popup
- Level 1 portals show incorrect "resonator level(s) needed for next portal level" HOT 3
- Feature Request: OSM plugin: Add more raster tile services HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ingress-intel-total-conversion.