iknite / cookiecutter-ansible-role Goto Github PK

Currently this cookiecutter is not following at least three of the Ansible Galaxy best practices:

1. README.md should be formatted with markdown: see pull request #9
2. Prefix variable names with the role name: can be fixed by editing this line
3. Integrate your roles with Travis CI: for this one I opened an issue (#6) and a pull request (#7)

Thoughts?

Found it by accident. I figured you'd like to know :)

post_gen_project.py is calling a cookiecutter function that is only found in this fork:
https://github.com/luzfcb/cookiecutter

from cookiecutter.prompt import query_yes_no
should be
from cookiecutter.prompt import read_user_yes_no
and the function calls changed accordingly. Note, you must provide a default_value in the call now.

def configure_role():
    print('\n\nROLE CONFIGURATION:\n===================')
    for folder_name, folder in folders.items():
        if read_user_yes_no(folder['question'], default_value=u'yes'):

            try:
                # this file has to be there, git doesn't store empty folders.
                os.remove(os.path.join(folder_name, '.empty'))
            except OSError:
                pass

            if 'hint' in folder:
                with open('{}/main.yml'.format(folder_name), 'a') as fp:

                    if 'pre_hint' in folder:
                        if read_user_yes_no(folder['pre_hint'], default_value=u'yes'):
                            fp.write(folder['pre_action'])

Currently generated roles do not include any test facility.

I'll provide a pull request that implements testing with Test-Kitchen configured with the kitchen-docker driver,
and kitchen-inspec.

Let's talk about this :)

Thank you for this repo, it's a terrific time saver. One issue I noticed:

if read_user_yes_no(folder['question'], default_value=u'no'):
if read_user_yes_no(folder['pre_hint'], default_value=u'no'):

Should be

if read_user_yes_no(folder['question'], default_value=u'no') == 'yes':
if read_user_yes_no(folder['pre_hint'], default_value=u'no') == 'yes':

Otherwise they always evaluate to true and we are still prompted for the values if we set the default to 'no'.