illandril / foundryvtt-turn-marker Goto Github PK

Is your feature request related to a problem? Please describe.
The turn markers show up on top of the Fog of War, so they can be seen even if the token moving cannot.

Describe the solution you'd like
Hide turn markers that are behind the Fog of War.

Ideally, the markers would be hidden based on what the Fog of War looked like at the time the movement happened (e.g. if someone moves and then turns on a light, those who couldn't see before the light was on shouldn't suddenly be able to see the movement path). This may get complicated though for users who can control multiple characters - they should be able to see the markers for anything any of their controlled characters can see, not just their active character.

GMs should not be restricted to Fog of War for visibility.

Describe the bug
A clear and concise description of what the bug is.

What steps did you take before experiencing the problem?
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

What did you expect to happen?
A clear and concise description of what you expected to happen.

What happened instead?
A clear and concise description of what happened that you did not expect to happen.

Screenshots

Foundry Versions

• Version of this module:
• Foundry Version:
• System Name and Version:
• Browser Name and Version:

What other modules did you have active when experiencing this issue (include both names and versions)?
Add the name and version of any other modules you had active when you experienced this issue. If you are able, please try to reproduce the issue with the least number of other modules active as possible, to help narrow down the specific cause of the problem in case the problem is caused by a conflict between modules.

Additional context
Add any other context about the problem here (ex. any settings for Foundry, the System, and/or Modules that you think may be related).

When ending turn on a player's client that error notification pops up, with the corresponding error logged in console.

In the module.js:279 in the Hooks.on("updateCombat", (a,b,c,d)=>{}) a check for if (game.user?.isGM) return; should be fixing this.

PS: Good one! My new favorite Turn Marker module 👍

ps2: Just realised that this will not fix properly, as the foot prints won't be removed from the player's client with the above change, so it is more complicated than that 😅

Is your feature request related to a problem? Please describe.
I find off-turn movement being blocked will also block the movement of tokens (e.g. animal companions) created using Pf2e Companion Compendia. These Actors are moved on their controlling PC's turn and don't get added to initiative order, effectively blocking players from moving them without GM assistance during combat.

Describe the solution you'd like
When token movement is unblocked for an actor during its turn, movement is also unblocked for other tokens owned by the same player. Perhaps this can be somehow restricted to actors with a specific characteristic in their character sheet (e.g. "Minion") to account for Eidolons / Familiars / Animal Companions (which move on their master's turn.)

Describe alternatives you've considered
At the moment I am having my druid ping the map where she would like her animal companion moved to and using the "m" key to override. It's not as nice as her being granted movement of the token directly but it works without having to disable the feature.

What system(s) do you want this feature to work with?
Pathfinder 2e

What other modules do you use that you want to ensure work well with this feature?
PF2e Companion Compendia

Additional context
Add any other context or screenshots about the feature request here.