Giter VIP home page Giter VIP logo

laravel-heyman's Issues

Improvement suggestion

Hi, i'm really in love with what you did and the fact that, it doesn't necessarily need to be added to an existing code (Controller) makes it more flexible.

However, i have an issue with the spell termination. If you say "whenDoingThis", this assume the action has already taken place, and some might not understand that "whenDoingThis" is occuring before.

So i would like to suggest renaming "when.." to "before...". This can increase the possibility because it will be possible to do something like "afterDoingThis".

Anyway, good job. I might use it on my upcoming projects.

Declarative style in Testing

It is not an issue, it is more a feature, but I would like to use this declarative style in my tests, do you think it is possible to do this?

Error with db:seed

When I make the command db: seed I get the following error: 'Undefined index: eloquentChecks'

laravel 10 compatibility issue

Error on require in laravel v10

Using version ^2.2 for imanghafoori/laravel-heyman
./composer.json has been updated
Running composer update imanghafoori/laravel-heyman
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- imanghafoori/laravel-heyman[2.2.0, ..., 2.2.7] require laravel/framework ~5.3 -> found laravel/framework[v5.3.0, ..., v5.8.38] but it conflicts with your root composer.json require (^10.0).
- imanghafoori/laravel-heyman[2.2.8, ..., v2.2.34] require laravel/framework ~5.1 -> found laravel/framework[v5.1.0, ..., v5.8.38] but it conflicts with your root composer.json require (^10.0).
- imanghafoori/laravel-heyman[v2.2.35, ..., v2.2.43] require laravel/framework ~5.1|6.* -> found laravel/framework[v5.1.0, ..., v5.8.38, v6.0.0, ..., v6.20.44] but it conflicts with your root composer.json require (^10.0).
- imanghafoori/laravel-heyman[v2.2.44, ..., v2.2.45] require laravel/framework ~5.1|6.|7. -> found laravel/framework[v5.1.0, ..., v5.8.38, v6.0.0, ..., v6.20.44, v7.0.0, ..., v7.30.6] but it conflicts with your root composer.json require (^10.0).
- imanghafoori/laravel-heyman[v2.2.46, ..., v2.2.52] require laravel/framework ~5.1|6.|7.|8.* -> found laravel/framework[v5.1.0, ..., v5.8.38, v6.0.0, ..., v6.20.44, v7.0.0, ..., v7.30.6, v8.0.0, ..., v8.83.27] but it conflicts with your root composer.json require (^10.0).
- imanghafoori/laravel-heyman[v2.2.53, ..., v2.2.54] require laravel/framework ~5.1|6.|7.|8.|9. -> found laravel/framework[v5.1.0, ..., v5.8.38, v6.0.0, ..., v6.20.44, v7.0.0, ..., v7.30.6, v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.0] but it conflicts with your root composer.json require (^10.0).
- Root composer.json requires imanghafoori/laravel-heyman ^2.2 -> satisfiable by imanghafoori/laravel-heyman[2.2.0, ..., v2.2.54].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require imanghafoori/laravel-heyman:*" to figure out if any version is installable, or "composer require imanghafoori/laravel-heyman:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

cannot install the package

I'm using PHP 7.3.8 and Laravel 7
I got the following error when trying to install the package.

Using version ^2.2 for imanghafoori/laravel-heyman
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)

Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar:///usr/bin/composer/src/Composer/DependencyResolver/Solver.php on line 223

Any suggestion is appreciated.

Out of memory error

This problem happened to me several times in the past but I did not report it thinking it could be several things.
But after encountering this problems several times during installing laravel-heyman, I try to reproduce the error.

After installing new laravel project with "laravel new name"
then run "composer require imanghafoori/laravel-heyman"
I got the following error.

composer require imanghafoori/laravel-heyman
Using version ^2.2 for imanghafoori/laravel-heyman
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
PHP Fatal error:  Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar://C:/ProgramData/ComposerSetup/bin/composer.phar/src/Composer/DependencyResolver/Solver.php on line 223

Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar://C:/ProgramData/ComposerSetup/bin/composer.phar/src/Composer/DependencyResolver/Solver.php on line 223

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.

Environment: Windows 10, PHP 7.4, composer 1.10, laravel installer 4.0

Some grouped suggestions

New Method : AssertThat( boolean )

As what i can see, the library is closely linked to plain Laravel installation. However, many out there already have a laravel application with their superset of functions (classes). So, we might introduce an asset true (or assertThat) method, which give the developper the capacity to to his own assetion and proceed (or not) the even.

Example :

use App\Factory\Post as PostFactory;
// ...
HeyMan::whenYouDelete( App\Models\Post::class )
->assertThat( PostFactory::OnePostLeft() )
// ...

New Method : redirectTo()

Having to write down ->redirect()->to()... makes the chain more longer. We might implement a method like ->redirectTo() which join both methods.

New Method : otherwiseThrow( \Exception )

Well, we're handling exception in a different ways on our laravel application. I assume many might have a different view (message) for different exceptions. It might be interesting on the chain to throw an exception.
Edit : i've seen that there is a Exception method, we might then consider reducing the chain.

Example :

use App\Guards\HeavenGuard;
use Illuminate\Support\Auth;
use App\Exceptions\NotForYouException;
// ...
HeyMan::whenYouVisitUrl(  '/paradise'  )
->assertThat( HeavenGuard::isBlessed( Auth::user() ) ) // new method
->otherwiseThrow( NotForYouException::class )
// ...

New method : whenYouVisiteRoute()

instead of typing down the URL with slashes, we might have a route support method.

How can I use whenYouCallAction() with custom controllers namespace?

Dear @imanghafoori1, I am very attracted to use this package on my new project. But have a question since I use Dingo/Api package with this.

I want do something like bellow:

HeyMan::
whenYouCallAction('App\Api\V1\Controllers\SomeController@action')
...

I saw this line where you hard code the controllers' namespace

return app()->getNamespace().'\\Http\\Controllers\\'.$action;
my question is; how can I use my own namespace on whenYouCallAction function?

HeyMan and Laravel policy

Is there a way to use HeyMan together with Laravel policy?
I only found an example for Gate but no policy anywhere.

Thanks in advance.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.