Comments (3)
Diff of dplyr and RSQLServer mod of build_query
:
diff -r
1,2c1,2
< build_query <- function(x, limit = NULL) {
< assert_that(is.null(limit) || (is.numeric(limit) && length(limit) == 1))
---
> build_query <- function (x, top = NULL) {
> assertthat::assert_that(is.null(top) || (is.numeric(top) && length(top) == 1))
4c4
< translate_sql_q(expr, tbl = x, env = NULL, ...)
---
> dplyr::translate_sql_q(expr, tbl = x, env = NULL, ...)
13c12
< vars <- auto_names(select)
---
> vars <- dplyr:::auto_names(select)
19,20c18,20
< select_sql <- translate(x$select, window = uses_window_fun(x$select, x))
< vars <- auto_names(x$select)
---
> select_sql <- translate(x$select,
> window = dplyr:::uses_window_fun(x$select, x))
> vars <- dplyr:::auto_names(x$select)
34c34
< if (!uses_window_fun(x$where, x)) {
---
> if (!dplyr:::uses_window_fun(x$where, x)) {
40,42c40
< base_query <- update(x,
< group_by = NULL,
< where = NULL,
---
> base_query <- update(x, group_by = NULL, where = NULL,
45,46c43,44
< from_sql <- build_sql("(", base_query$sql, ") AS ", ident(unique_name()),
< con = x$src$con)
---
> from_sql <- dplyr::build_sql("(", base_query$sql, ") AS ",
> dplyr::ident(unique_name()), con = x$src$con)
53,54c50,51
< limit = limit)
< query(x$src$con, sql, vars)
---
> top = top)
> dplyr::query(x$src$con, sql, vars)
from rsqlserver.
Only differences are qualified calls to dplyr functions and renaming parameter from limit
to top
from rsqlserver.
Removed build_query in 7954825 and will reintroduce properly along with an implementation of update
to fix #49
from rsqlserver.
Related Issues (20)
- Fix upstream breaks introduced by dplyr/dbplyr refactoring
- Clean up v0.3 NEWS
- Trying to SELECT: Error in rlang::as_function(.f, ...) : unused argument (length = 0) HOT 1
- select() and rename() don't rename table columns HOT 1
- Collation error HOT 3
- Speed up MSFT driver's connection HOT 2
- Plans to re-submit to CRAN? HOT 11
- Building RSQLServer fails on rlang dependency HOT 1
- Speed up test harness
- Creating tbl on non-default DB and Schema Fails HOT 1
- Dependency on dplyr HOT 8
- Error on mutating bitfield column with TRUE, FALSE
- version 0.3 can't be installed on ubuntu 16.04 HOT 8
- src_sqlserver' is not an exported object from 'namespace:RSQLServer HOT 8
- Update to latest release of JDBC
- Temporary tables not cleaned up HOT 4
- Cannot begin a nested transaction after dbRollback
- the performance of dbWriteTable is ok?ths.
- Translator is missing window functions
- Update documentation to accommodate dev version of DBI HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rsqlserver.