incuna / incuna-feincms Goto Github PK

It would be nice to have a login-only boolean flag on navigation items so that we can add items that show only when the user is authenticated.

Docs would be useful

Hey @maxpeterson, I've been looking at refactoring {% feincms_page_menu %}, for understanding and simplification's sake, but I'm worried that I'll break something. Could you please help me to understand a couple of things...

1. Can down ever be more than 1? If so, how? Here's the code and how it's used. Couldn't this just be context['down'] = True and {% if down %}<ul>{% ...? (Related to #1.)
2. I suspect that extra_context can only ever be None? Amirite? If so, I'll remove it.
3. Why would css_class ever already be in the context? Has this ever been used?
4. For that matter, have we ever required anything in the context of a page for use in incunafein/page/menuitem.html? In other words, do we have to do the context.push(), context.pop() dance instead of just using a fresh Context or dict for each loop over get_next_item?

This repo is public. No reason not to.

This filter is in the django-incuna non-FOSS project.

This has been moved into incuna-videos

Anyone ?