ind-igo / forge-safe Goto Github PK

Hey @ind-igo, thanks for this. I'd like to use it with my Trezor and happy to PR into the repo instead of forking.

Just reviewing the BatchScript.sol file and want to double check the implementation approach with you to confirm I'm not missing anything:

https://github.com/ind-igo/forge-safe/blob/main/src/BatchScript.sol#L68
Add hash of "trezor" as an option

https://github.com/ind-igo/forge-safe/blob/main/src/BatchScript.sol#L158
Add trezor to switch statement - I am assuming trezor supports the mnemonic index flag but I can't see documentation on it?

Cheers

Currently transactions are sent in the script without them modifying state. Transactions should be executed and modify state in a forked chain to allow chaining transactions

Dear Indigo,

I have been using the forge-safe submodule in my project and have found an issue. The forge-std version being used within the forge-safe submodule conflicts with the latest version of forge-std.

When I attempt to use the forge-safe submodule alongside the latest version of forge-std, I get an error: Error (9097): Identifier already declared. This error indicates that there are some shared identifiers between the two libraries that have been declared more than once, thus causing a conflict.

I'm not sure about the best course of action to resolve this conflict. One solution I made is to update the forge-std version used within the forge-safe submodule to the latest one. However, this might require some changes to the forge-safe code to ensure compatibility.

Please review the issue. I am looking forward to your guidance on resolving this problem.

Thank you for your attention to this matter.

Best Regards,
Roy

In the example:

import {BatchScript} from "forge-safe/BatchScript.sol";

...

function run(bool send_) public {
        string memory gm = "gm";
        address greeter = 0x1111;

        bytes memory txn = abi.encodeWithSelector(
            Greeter.greet.selector,
            gm
        );
        addToBatch(greeter, 0, txn);

        executeBatch(safe, send_);
}

It is unclear whether run is an internal function inside a contract that inherits run. Could you clarify whether that is the case. Because how else are addToBatch and executeBatch being called?