Giter VIP home page Giter VIP logo

indented.scriptanalyzerrules's People

Contributors

chrislgardner avatar indented-automation avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

indented.scriptanalyzerrules's Issues

Rule UseSyntacticallyCorrectExamples fails if parameter uses type that is not loaded

If the rule is testing a function hat has a parameter with a type that is not loaded into the session the rule fails on all parameters in all examples.

For example if having this parameter:

param
(
    [Parameter()]
    [Microsoft.SqlServer.Management.Smo.Server]
    $SqlServerObject
)

This row will return the function but the property Parameters will be $null

which result in that this evaluation always return $true

$_ -is [CommandParameterAst] -and $_.ParameterName -notin $functionInfo.Parameters.Keys

Suggest adding a error message when $null -eq $functionInfo.Parameters saying something like "Parameters of the function X could not be parsed, this can for example be due to that a type that is used by a parameter is not loaded into the session.".

I worked around this by loading stubs classes before running Invoke-ScriptAnalyzer.

PSUseSyntacticallyCorrectExamples doesn't understand examples using splats

When testing the following code

`
function Start-Test {
<#
.SYNOPSIS
Test program

.DESCRIPTION
Test program to demonstrate ScriptAnalyzerRules doesn't accept splatted examples

.EXAMPLE
    $testSplat = @{
        'Parameter1' = "1"
    }
    Start-Test @testSplat

#>
[cmdletbinding()]
param (
    [parameter(Mandatory = $true, HelpMessage = "Parameter1")]
    [String]$Parameter1
)

Write-Host $Parameter1

}
`

using the command Invoke-ScriptAnalyzer -Path .\SplatExamples.psm1 -CustomRulePath c:\gitrepos\ScriptAnalyzerRules\Indented.CodingConventions\

the command returns

Unable to determine parameter set used by example 1 for the function Start-Test

however the splat is valid and the function works as intended

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.