indutny / hpack.js Goto Github PK

The license is embedded in the README, can we have it as a separate license file?

I was looking and this implementation and I have question regarding dynamic table specifically how reverse lookup works.

If I understand this correctly It first searches static table then goes to the dynamic table where it first checks if name + value are the same if that is not so it checks if only name is the same and if it is and it is not in the static table it returns this value.

But lets say for example that we have a dynamic table like this:

1. "custom-name": "custom-value-1"
2. ":status": "202"
3. "custom-name": "custom-value-2"

And you are encoding header"custom-name": "custom-value-2". In this case since header "custom-name" in not in the static table and because header "custom-name": "custom-value-1" is on the top of dynamic table the encoder will take index 1 and do literal encoding for value instead of using direct match of both name and value at index 3.

Is my understanding of this correct? And if so is this a bug?

Hey there, our team noticed that the latest webpack-dev-server version is failing when running due to the inability to find hpack.js. We were able to resolve the issue by adding "main": "lib/hpack.js" to the top of the package.json. Not sure if this is a known issue.

Thanks!

Hello,

Since so many people depend on your lovely npm module via webpack-dev-server, would you be open to a PR to bump your dependency on readable-stream to the latest version? There have been several improvements since v2 including removing the infamous isArray npm module.