Attributes on parameters of method signature are not detected as part of method signature about infection HOT 7 CLOSED

I don't know if the recent update of the playground has changed something, but my example is no longer passing.
Now, it is detected as uncovered like it is on my local or my servers.

• https://infection-php.dev/r/5wee with Infection 0.26.13 and PHPUnit 9.5.9
• https://infection-php.dev/r/n7m3 with Infection 0.26.20 and PHPUnit 10.1.2

Maybe the line format normalization is not applied before the analysis but after, which could explain why it is detected as uncovered while it is (same reason that I explained a previous comments here).

I'll try to propose a PR about it.

from infection.

I managed to provide a PR with some unit tests: #1847

If you have tips or suggestions, I'll be pleased to apply them ASAP.

Thanks a lot!

from infection.

It's now killed https://infection-php.dev/r/p3e2 👍

from infection.

Can you make an example using Infection's playground? https://infection-php.dev/

Never mind, saw you last observation. Can you at least share it?

from infection.

I wonder if we could skip mutating PHP Attributes for now.

from infection.

Never mind, saw you last observation. Can you at least share it?

Yes of course. I wrote it few days ago to open an issue here but that's how I discovered the mutant is killed as expected in the playground, and I didn't understood why until I came into PHP Infection's source code and I understood how the coverage is bound to the mutation.

https://infection-php.dev/r/5wee

You'll see on the playground that the attribute is no longer on line 10 of the sources but normalized at line 8, which is why, IMO, it passes on playground. If you can ask for no line normalization on the playground, you should be able to reproduce my example.

from infection.

I wonder if we could skip mutating PHP Attributes for now.

Technically, the ReflectionVisitor could add a new custom attribute on the PhpParser\Node elements to detect if such node is into a PhpParser\AttributeGroup (= current node has any ancestor of type PhpParser\AttributeGroup) and then we could generate no mutation for nodes having such custom attribute.

Functionnally, I'm not a fan of such idea as I really do think that some static value given to arguments of attributes should be tested, and tests should be tested to ensure they are actually testing those values as expected. But regarding the impacts PHP Attributes can have on the good behavior of PHP Infection, maybe that's the wiser decision to take.

from infection.