Do not mutate `instanceof` in `assert()` about infection HOT 7 CLOSED

That's true. For this, we specifically has a feature to ignore mutants, see updated playground: https://infection-php.dev/r/p3xk

{
    "mutators": {
        "@default": true,
        "global-ignoreSourceCodeByRegex": [
            "assert\\(.*\\);"
        ]
    }
}

from infection.

@maks-rafalko Wouldn't it be better to ignore assert(true) by default? It just does not make sense at all to have it reported.
I don't know if it is possible to do that internally for specific rules (instanceof) or for assert(true) in general. So ignore it if it's not simple to do.
I am just looking for a way, to disable specific rules for specific statements, so I don't turn off rules that are unrelated to problem. Asserts generally should pass and I still want to know if there is something wrong with them.

from infection.

I don't know if it is possible to do that internally for specific rules (instanceof) or for assert(true) in general. So ignore it if it's not simple to do.

It's absolutely doable, and I agree we can ignore such mutation on Mutator level. If you want to help, please start here:

For now, just use ignoreSourceCodeByRegex - this will solve your issue

from infection.

I doubt it will be easy though. Infection doesn't come with a static analyzer so it can't tell if your assert() is a global method or a method imported from somewhere else.

from infection.

An alternative solution could be @infection-ignore instanceof. While not the perfect solution for this problem, it is much more versatile. I don't know much yet about infection internals, but it could be similar to @infection-ignore-all

from infection.

An alternative solution could be @infection-ignore instanceof.

while not the same, but we already have a feature on config level for ignoring globally or per-mutator: https://infection.github.io/guide/how-to.html#Do-not-mutate-the-source-code-matched-by-regular-expression

{
    "mutators": {
        "InstanceOf_": {
            "ignoreSourceCodeByRegex": [
                "assert\\(.*\\);"
            ]
        }
    }
}

I doubt it will be easy though. Infection doesn't come with a static analyzer so it can't tell if your assert() is a global method or a method imported from somewhere else.

don't think it's a problem to be honest. We don't check all the internal functions (array_map, etc.) whether they are native or from other package, but still mutate them. IMO it's ok to not mutate instanceof in any assert() function, be it native or not.

from infection.

Thank you for reporting, fixed

from infection.