Compatibility with composer-bin-plugin about infection HOT 3 OPEN

but perhaps I'm missing something, maybe reflection is also used.

Yes :) It uses parses the AST of the source code and may leverage reflection for some mutations. It could be delegated to BetterReflection at some point, but not sure what the performance impact would be.

from infection.

Hi!

I would like to be able to use it with Infection, too.

I think it's a bad idea in the current state of things. As you noted, infection need to autoload your code. So if you install it in a different composer.json (which is what bamarni/composer-bin-plugin does), then you can end up with various issues:

• The same class is declared in both infection (or its dependencies) and your project: in this case the second declaration will not be loaded (and their implementation may differ, PHP will just see "this class has been loaded already" and won't load it again).
• Same with functions, in which case if they don't have the if (!function_exists(...)) which you will end up with declaring twice a function which crashes PHP.

Using Infection PHAR would be no different if it was a regular PHAR. However Infection uses PHP-Scoper to address those issues.

As the main contributor and a heavy user of bamarni/composer-bin-plugin, I totally understand the concern of wanting to isolate tools dependencies. However, I think this approach cannot be systematic due to the reasons outlined above. To be able to do so, you need either a tool that doesn't autoload your code, or a tool for which its code is scoped (like Infection PHAR, or like the phpstan package which ships the scoped PHPStan PHAR).

A possible solution however, would be to do like PHPStan, i.e. have a proxy package which ships the isolated PHAR. I do not know how that works with extensions though, IIRC PHPStan managed to get around with it, I do not know what it entails for Infection.

from infection.

Thank you for the fast and detailed answer!

Of course, if Infection needs to autoload project dependencies, it makes it impossible to use it with composer-bin-plugin and I'll have to switch to PHAR version; thanks to PHP-Scoper, it's possible.

But I still don't completely understand why Infection needs to load project's dependencies. I thought that it uses PHPUnit CLI to run tests and PHP-Parser to parse sources; but perhaps I'm missing something, maybe reflection is also used. Anyway, the tool is great and helps a lot.

from infection.